From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11DBBC4360C for ; Fri, 27 Sep 2019 07:31:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3A342054F for ; Fri, 27 Sep 2019 07:31:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbfI0HbO (ORCPT ); Fri, 27 Sep 2019 03:31:14 -0400 Received: from mail.monom.org ([188.138.9.77]:57162 "EHLO mail.monom.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbfI0HbN (ORCPT ); Fri, 27 Sep 2019 03:31:13 -0400 Received: from mail.monom.org (localhost [127.0.0.1]) by filter.mynetwork.local (Postfix) with ESMTP id 0C383500587; Fri, 27 Sep 2019 09:31:12 +0200 (CEST) Received: from localhost (b9168f76.cgn.dg-w.de [185.22.143.118]) by mail.monom.org (Postfix) with ESMTPSA id D5EBC500483; Fri, 27 Sep 2019 09:31:11 +0200 (CEST) Date: Fri, 27 Sep 2019 09:31:11 +0200 From: Daniel Wagner To: Bart Van Assche Cc: qla2xxx-upstream@qlogic.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry() Message-ID: <20190927073111.jm3jjmm5gcr6ylc7@beryllium.lan> References: <20190926074637.77721-1-dwagner@suse.de> <5d5931ef-7ffa-3f3f-bb5e-5379c1716d04@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d5931ef-7ffa-3f3f-bb5e-5379c1716d04@acm.org> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > Should the following be added? > > Fixes: 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not > called from the completion path") Good point. Just send out and updated version > Anyway: > > Reviewed-by: Bart Van Assche Thanks! Daniel