From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381C4C4360C for ; Fri, 27 Sep 2019 18:51:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C60320872 for ; Fri, 27 Sep 2019 18:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569610317; bh=J6QORNmaoNLFhvTKSqBFZNVrlw5KFUYdXdn4NawkZH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nZXQ3CcVhX2weZ53t5EY2W+1i2CUOhxY5l5xSv1GIkBdIsa9tbJVRFOfb/awrZsJ9 ameVCM+KeCUZRE5S3WFZi6HDMjfS3/Vw3qluaSaY5v9c6CzP2ymQh6rRBVzkBZlxrr 8U8MlYK8xxSGnsU4sB4VnHy1FfMWM++gCfkMeh2U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728108AbfI0Sv4 (ORCPT ); Fri, 27 Sep 2019 14:51:56 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:37171 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbfI0Sv4 (ORCPT ); Fri, 27 Sep 2019 14:51:56 -0400 Received: by mail-ot1-f68.google.com with SMTP id k32so3140586otc.4; Fri, 27 Sep 2019 11:51:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=d41cCTl7w3rkM7T7TH1Wjkv6CwKEi+5QRtnS63WD5ZM=; b=Pc7c0jdRUhiQMJMyfJBbfl6M1L8VwnUvd5Zn1MSnnIBqdqVwqBAtO6HzVHCN36jO3I QODPHIU25vl89//TY7kO9Jwt+E2FDC/KKxphI+2U/3JI/W//HsPMVZyx4VRnk2+C7lsK LCJEhlZOzWzc8prg3L6q/GRThvmSArhLnljK7YHe9rs7hTjs4N0kZHmMPfY5vOqLhF1t DPKDgHemyTC9poSdSEZ+Ex6BDKYmFUbU+lhHuBlZZRJJFclOI0n3r7RJUaAHB0DZwRIe mbNBg1qM6H/OJ8BGlsvD/V41cXhDcEuQwKzKhqBR3ywC/S5y31uK6CNZTFT/hpYVFD+c ElwQ== X-Gm-Message-State: APjAAAXx3q9hYjaIaDrWYiKMhe92/u6YD5uywBGlwOaZwV6MrQ5UBtqN v52PHZyOoYi0pPBYwA+v3A== X-Google-Smtp-Source: APXvYqy7kAP35+kBMD+IB6YfX5awR9sKBq4fbOg1XNya+RBpUkbPY3uEzjMNx9j7YtN3dMZyiE8Z7Q== X-Received: by 2002:a05:6830:443:: with SMTP id d3mr4430310otc.93.1569610314662; Fri, 27 Sep 2019 11:51:54 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id v75sm1961767oia.6.2019.09.27.11.51.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2019 11:51:53 -0700 (PDT) Date: Fri, 27 Sep 2019 13:51:53 -0500 From: Rob Herring To: Adam Ford Cc: dri-devel@lists.freedesktop.org, adam.ford@logicpd.com, Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 2/3] dt-bindings: Add Logic PD Type 28 display panel Message-ID: <20190927185153.GA982@bogus> References: <20190925184239.22330-1-aford173@gmail.com> <20190925184239.22330-2-aford173@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190925184239.22330-2-aford173@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 25, 2019 at 01:42:37PM -0500, Adam Ford wrote: > This patch adds documentation of device tree bindings for the WVGA panel > Logic PD Type 28 display. > > Signed-off-by: Adam Ford > --- > V3: Correct build errors from 'make dt_binding_check' > V2: Use YAML instead of TXT for binding > > diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml > new file mode 100644 > index 000000000000..74ba650ea7a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.yaml > @@ -0,0 +1,31 @@ > +# SPDX-License-Identifier: (GPL-2.0+ OR X11) (GPL-2.0-only OR BSD-2-Clause) please. X11 is pretty much never right unless this is copyright X Consortium. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/logicpd,type28.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Logic PD Type 28 4.3" WQVGA TFT LCD panel > + > +maintainers: > + - Adam Ford > + You need: allOf: - $ref: panel-common.yaml# > +properties: > + compatible: > + const: logicpd,type28 > + > + power-supply: > + description: Regulator to provide the supply voltage > + maxItems: 1 > + > + enable-gpios: > + description: GPIO pin to enable or disable the panel > + maxItems: 1 > + > + backlight: > + description: Backlight used by the panel > + $ref: "/schemas/types.yaml#/definitions/phandle" These 3 are all defined in the common schema, so you just need 'true' for the value to indicate they apply to this panel and to make 'additionalProperties: false' happy. > + > +required: > + - compatible Are the rest really optional? > + > +additionalProperties: false > -- > 2.17.1 >