From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Paul Burton" <paul.burton@mips.com>,
linux-mips@linux-mips.org, joe@perches.com,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-mips@vger.kernel.org, "Sasha Levin" <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.9 06/13] firmware: bcm47xx_nvram: Correct size_t printf format
Date: Sun, 29 Sep 2019 13:36:16 -0400 [thread overview]
Message-ID: <20190929173625.10003-6-sashal@kernel.org> (raw)
In-Reply-To: <20190929173625.10003-1-sashal@kernel.org>
From: Florian Fainelli <f.fainelli@gmail.com>
[ Upstream commit feb4eb060c3aecc3c5076bebe699cd09f1133c41 ]
When building on a 64-bit host, we will get warnings like those:
drivers/firmware/broadcom/bcm47xx_nvram.c:103:3: note: in expansion of macro 'pr_err'
pr_err("nvram on flash (%i bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
^~~~~~
drivers/firmware/broadcom/bcm47xx_nvram.c:103:28: note: format string is defined here
pr_err("nvram on flash (%i bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
~^
%li
Use %zu instead for that purpose.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@linux-mips.org
Cc: joe@perches.com
Cc: Rafał Miłecki <zajec5@gmail.com>
Cc: linux-mips@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/firmware/broadcom/bcm47xx_nvram.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/broadcom/bcm47xx_nvram.c b/drivers/firmware/broadcom/bcm47xx_nvram.c
index 0b631e5b5b843..8632b952d77c5 100644
--- a/drivers/firmware/broadcom/bcm47xx_nvram.c
+++ b/drivers/firmware/broadcom/bcm47xx_nvram.c
@@ -100,7 +100,7 @@ static int nvram_find_and_copy(void __iomem *iobase, u32 lim)
nvram_len = size;
}
if (nvram_len >= NVRAM_SPACE) {
- pr_err("nvram on flash (%i bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
+ pr_err("nvram on flash (%zu bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
nvram_len, NVRAM_SPACE - 1);
nvram_len = NVRAM_SPACE - 1;
}
@@ -152,7 +152,7 @@ static int nvram_init(void)
header.len > sizeof(header)) {
nvram_len = header.len;
if (nvram_len >= NVRAM_SPACE) {
- pr_err("nvram on flash (%i bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
+ pr_err("nvram on flash (%zu bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
header.len, NVRAM_SPACE);
nvram_len = NVRAM_SPACE - 1;
}
--
2.20.1
next prev parent reply other threads:[~2019-09-29 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 17:36 [PATCH AUTOSEL 4.9 01/13] clk: jz4740: Add TCU clock Sasha Levin
2019-09-29 17:36 ` [PATCH AUTOSEL 4.9 02/13] MIPS: tlbex: Explicitly cast _PAGE_NO_EXEC to a boolean Sasha Levin
2019-09-29 17:36 ` [PATCH AUTOSEL 4.9 03/13] mfd: intel-lpss: Remove D3cold delay Sasha Levin
2019-09-29 17:36 ` [PATCH AUTOSEL 4.9 04/13] PCI: tegra: Fix OF node reference leak Sasha Levin
2019-09-29 17:36 ` [PATCH AUTOSEL 4.9 05/13] ARM: 8898/1: mm: Don't treat faults reported from cache maintenance as writes Sasha Levin
2019-09-29 17:36 ` Sasha Levin [this message]
2019-09-29 17:36 ` [PATCH AUTOSEL 4.9 07/13] HID: apple: Fix stuck function keys when using FN Sasha Levin
2019-09-29 17:36 ` [PATCH AUTOSEL 4.9 08/13] security: smack: Fix possible null-pointer dereferences in smack_socket_sock_rcv_skb() Sasha Levin
2019-09-29 17:36 ` [PATCH AUTOSEL 4.9 09/13] ARM: 8903/1: ensure that usable memory in bank 0 starts from a PMD-aligned address Sasha Levin
2019-09-29 17:36 ` [PATCH AUTOSEL 4.9 10/13] fat: work around race with userspace's read via blockdev while mounting Sasha Levin
2019-09-29 17:36 ` [PATCH AUTOSEL 4.9 11/13] hypfs: Fix error number left in struct pointer member Sasha Levin
2019-09-29 17:36 ` [PATCH AUTOSEL 4.9 12/13] ocfs2: wait for recovering done after direct unlock request Sasha Levin
2019-09-29 17:36 ` [PATCH AUTOSEL 4.9 13/13] kmemleak: increase DEBUG_KMEMLEAK_EARLY_LOG_SIZE default to 16K Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190929173625.10003-6-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=f4bug@amsat.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=stable@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®