From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83827C4360C for ; Mon, 30 Sep 2019 05:35:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5659E21906 for ; Mon, 30 Sep 2019 05:35:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="iBn80Ffg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729547AbfI3FfD (ORCPT ); Mon, 30 Sep 2019 01:35:03 -0400 Received: from mail.skyhub.de ([5.9.137.197]:60684 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbfI3FfD (ORCPT ); Mon, 30 Sep 2019 01:35:03 -0400 Received: from zn.tnic (p200300EC2F058B001D5F1DA44E6EEA2E.dip0.t-ipconnect.de [IPv6:2003:ec:2f05:8b00:1d5f:1da4:4e6e:ea2e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2F3BC1EC066F; Mon, 30 Sep 2019 07:35:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1569821701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=8CR7ck8vfKUMhI8YQHgFIi0/p3DjgyqAY7n/IJC7LYU=; b=iBn80Ffg9J0LK7Ykuf3dpyzHyY+l5XeQxrpqu5Q1Snb2O3ZHEHtkT4RzdWH05w4YiXl00w jHu7ul3goL9jIglJPh+Wi+C4wovxSJBXlCIw9g1Qp3JxWvNBgC/0rAMcecBm9WoY9lYMAJ tpW8ENRUPG3QNes1D1Z2o2CSPxP3MCE= Date: Mon, 30 Sep 2019 07:34:58 +0200 From: Borislav Petkov To: Alexander Kapshuk Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, mhiramat@kernel.org, kbuild test robot Subject: Re: [PATCH RESEND] gen-insn-attr-x86.awk: Fix regexp warnings Message-ID: <20190930053458.GB29694@zn.tnic> References: <20190923114904.dd63949b3433376aeb4b7789@kernel.org> <20190924044659.3785-1-alexander.kapshuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190924044659.3785-1-alexander.kapshuk@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 24, 2019 at 07:46:59AM +0300, Alexander Kapshuk wrote: > gawk 5.0.1 generates the regexp warnings shown below: > GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c > awk: ../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator > awk: ../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operator > > Ealier versions of gawk are not known to generate these warnings. > > The gawk manual referenced below does not list characters ':' and '&' > as needing escaping, so 'unescape' them. > https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html > > Running diff on the output generated by the script before and after > applying the patch reported no differences. > > Signed-off-by: Alexander Kapshuk > Reported-by: kbuild test robot > Reviewed-by: Borislav Petkov This is not how Reviewed-by works. Read here: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes for future reference. I fixed it up now. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette