From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7127ECE587 for ; Tue, 1 Oct 2019 17:02:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3AAA2054F for ; Tue, 1 Oct 2019 17:02:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732618AbfJARCh (ORCPT ); Tue, 1 Oct 2019 13:02:37 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50000 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729383AbfJARCf (ORCPT ); Tue, 1 Oct 2019 13:02:35 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0E4B1154ECD6A; Tue, 1 Oct 2019 10:02:34 -0700 (PDT) Date: Tue, 01 Oct 2019 10:02:33 -0700 (PDT) Message-Id: <20191001.100233.2002881947003652758.davem@davemloft.net> To: wenyang@linux.alibaba.com Cc: alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, xlpang@linux.alibaba.com, zhiche.yy@alibaba-inc.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mscc: ocelot: add missing of_node_put after calling of_get_child_by_name From: David Miller In-Reply-To: <20190929065424.2437-1-wenyang@linux.alibaba.com> References: <20190929065424.2437-1-wenyang@linux.alibaba.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Oct 2019 10:02:34 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang Date: Sun, 29 Sep 2019 14:54:24 +0800 > of_node_put needs to be called when the device node which is got > from of_get_child_by_name finished using. > In both cases of success and failure, we need to release 'ports', > so clean up the code using goto. > > fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") > Signed-off-by: Wen Yang Applied.