From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F462C352AA for ; Wed, 2 Oct 2019 01:08:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA93420815 for ; Wed, 2 Oct 2019 01:08:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729585AbfJBBIS (ORCPT ); Tue, 1 Oct 2019 21:08:18 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55080 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727118AbfJBBIR (ORCPT ); Tue, 1 Oct 2019 21:08:17 -0400 Received: from localhost (unknown [IPv6:2603:3023:50c:85e1:b5c5:ae11:3e54:6a07]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4903C14C612AE; Tue, 1 Oct 2019 18:08:17 -0700 (PDT) Date: Tue, 01 Oct 2019 21:08:14 -0400 (EDT) Message-Id: <20191001.210814.415335033876213685.davem@davemloft.net> To: johan@kernel.org Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] hso: fix NULL-deref on tty open From: David Miller In-Reply-To: <20190930151241.25646-1-johan@kernel.org> References: <20190930151241.25646-1-johan@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Oct 2019 18:08:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold Date: Mon, 30 Sep 2019 17:12:41 +0200 > Fix NULL-pointer dereference on tty open due to a failure to handle a > missing interrupt-in endpoint when probing modem ports: > > BUG: kernel NULL pointer dereference, address: 0000000000000006 > ... > RIP: 0010:tiocmget_submit_urb+0x1c/0xe0 [hso] > ... > Call Trace: > hso_start_serial_device+0xdc/0x140 [hso] > hso_serial_open+0x118/0x1b0 [hso] > tty_open+0xf1/0x490 > > Fixes: 542f54823614 ("tty: Modem functions for the HSO driver") > Signed-off-by: Johan Hovold Applied, thanks.