From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F039C35280 for ; Wed, 2 Oct 2019 08:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58420218DE for ; Wed, 2 Oct 2019 08:20:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727647AbfJBIUQ (ORCPT ); Wed, 2 Oct 2019 04:20:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:52202 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726067AbfJBIUQ (ORCPT ); Wed, 2 Oct 2019 04:20:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EA74CACC6; Wed, 2 Oct 2019 08:20:14 +0000 (UTC) Date: Wed, 2 Oct 2019 10:20:06 +0200 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Vinod Koul Cc: Randy Dunlap , alsa-devel@alsa-project.org, Sanyog Kale , Pierre-Louis Bossart , linux-kernel@vger.kernel.org Subject: Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI Message-ID: <20191002081717.GA4015@kitsune.suse.cz> References: <20190830185212.25144-1-msuchanek@suse.de> <20190904093052.GQ2672@vkoul-mobl> <20190904124803.1700a65a@naga> <20190904114059.GU2672@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190904114059.GU2672@vkoul-mobl> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 04, 2019 at 05:10:59PM +0530, Vinod Koul wrote: > On 04-09-19, 12:48, Michal Suchánek wrote: > > On Wed, 4 Sep 2019 15:00:52 +0530 > > Vinod Koul wrote: > > > > > On 30-08-19, 11:56, Randy Dunlap wrote: > > > > On 8/30/19 11:52 AM, Michal Suchanek wrote: > > > > > Fixes the following warning on !ACPI systems: > > > > > > > > > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but > > > > > not used [-Wunused-function] > > > > > static int sdw_slave_add(struct sdw_bus *bus, > > > > > ^~~~~~~~~~~~~ > > > > > > > > > > Signed-off-by: Michal Suchanek > > > > > > > > Acked-by: Randy Dunlap > > > > > > > > I was about to send the same patch. > > > > > > So I have applied Srini's patches which add DT support and they use > > > sdw_slave_add(). So next tomorrow should not see this error as it is now > > > used by DT parts as well. > > > > > > So dropping this patch > > > > > > > That should fix the issue for me. I wonder if !ACPI !DT platforms are > > still a thing. > > Heh that should trigger this if we have one :D so should a lot more > which depend on some firmware! Actually s390x is built with !ACPI and !OF. While it supports PCI an virtio in practice only sound devices emulated by qemu are available. Also AFAICT the sounwire driver is useless without ACPI or OF so it should depend on them. Thanks Michal