mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Alex Deucher" <alexander.deucher@amd.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>
Cc: clang-built-linux@googlegroups.com,
	amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Arnd Bergmann <arnd@arndb.de>,
	Dingchen Zhang <dingchen.zhang@amd.com>,
	Harry Wentland <Harry.Wentland@amd.com>,
	Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
	David Francis <David.Francis@amd.com>,
	Mario Kleiner <mario.kleiner.de@gmail.com>
Subject: [PATCH 5/6] [RESEND] drm/amd/display: hide an unused variable
Date: Wed,  2 Oct 2019 14:01:26 +0200	[thread overview]
Message-ID: <20191002120136.1777161-6-arnd@arndb.de> (raw)
In-Reply-To: <20191002120136.1777161-1-arnd@arndb.de>

Without CONFIG_DEBUG_FS, we get a warning for an unused
variable:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6020:33: error: unused variable 'source' [-Werror,-Wunused-variable]

Hide the variable in an #ifdef like its only users.

Fixes: 14b2584636c6 ("drm/amd/display: add functionality to grab DPRX CRC entries.")
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This was a bugfix for a commit that landed in v5.4-rc1. The
fix was applied by Alex Deucher on Sep 19, but is still not
seen in linux-next.
Resending to make sure this makes it into v5.4-final, but
please ignore if this is already coming.
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 8cab6da512a0..7516a6436822 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -6019,7 +6019,9 @@ static void amdgpu_dm_enable_crtc_interrupts(struct drm_device *dev,
 	struct drm_crtc *crtc;
 	struct drm_crtc_state *old_crtc_state, *new_crtc_state;
 	int i;
+#ifdef CONFIG_DEBUG_FS
 	enum amdgpu_dm_pipe_crc_source source;
+#endif
 
 	for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state,
 				      new_crtc_state, i) {
-- 
2.20.0


  parent reply	other threads:[~2019-10-02 12:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 12:01 [PATCH 0/6] amdgpu build fixes Arnd Bergmann
2019-10-02 12:01 ` [PATCH 1/6] drm/amdgpu: make pmu support optional, again Arnd Bergmann
2019-10-02 12:01 ` [PATCH 2/6] drm/amdgpu: hide another #warning Arnd Bergmann
2019-10-02 12:01 ` [PATCH 3/6] drm/amdgpu: display_mode_vba_21: remove uint typedef Arnd Bergmann
2019-10-02 12:01 ` [PATCH 4/6] drm/amd/display: fix dcn21 Makefile for clang Arnd Bergmann
2019-10-02 14:17   ` Alex Deucher
2019-10-02 14:51     ` Arnd Bergmann
2019-10-02 15:12       ` Alex Deucher
2019-10-02 15:39         ` Arnd Bergmann
2019-10-02 16:33           ` Alex Deucher
2019-10-02 21:14   ` Nick Desaulniers
2019-10-02 21:24     ` Alex Deucher
2019-10-02 21:27       ` Nick Desaulniers
2019-10-02 12:01 ` Arnd Bergmann [this message]
2019-10-02 12:01 ` [PATCH 6/6] [RESEND] drm/amdgpu: work around llvm bug #42576 Arnd Bergmann
2019-10-02 16:51   ` Nick Desaulniers
2019-10-02 17:07     ` Nathan Chancellor
2019-10-02 21:06       ` Nick Desaulniers
2019-10-02 18:47 ` [PATCH 0/6] amdgpu build fixes Alex Deucher
2019-10-02 18:53   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191002120136.1777161-6-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=David.Francis@amd.com \
    --cc=David1.Zhou@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=daniel@ffwll.ch \
    --cc=dingchen.zhang@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.kleiner.de@gmail.com \
    --cc=nicholas.kazlauskas@amd.com \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®