From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C98CC4360C for ; Fri, 4 Oct 2019 13:42:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71AFF222C0 for ; Fri, 4 Oct 2019 13:42:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388724AbfJDNmb (ORCPT ); Fri, 4 Oct 2019 09:42:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:48308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388491AbfJDNmb (ORCPT ); Fri, 4 Oct 2019 09:42:31 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2990620700; Fri, 4 Oct 2019 13:42:30 +0000 (UTC) Date: Fri, 4 Oct 2019 09:42:28 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: Daniel Bristot de Oliveira , linux-kernel@vger.kernel.org, x86@kernel.org, Nadav Amit , Andy Lutomirski , Dave Hansen , Song Liu , Masami Hiramatsu Subject: Re: [PATCH 3/3] x86/ftrace: Use text_poke() Message-ID: <20191004094228.5a5774fe@gandalf.local.home> In-Reply-To: <20191004112237.GA19463@hirez.programming.kicks-ass.net> References: <20190827180622.159326993@infradead.org> <20190827181147.166658077@infradead.org> <20191002182106.GC4643@worktop.programming.kicks-ass.net> <20191003181045.7fb1a5b3@gandalf.local.home> <20191004112237.GA19463@hirez.programming.kicks-ass.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Oct 2019 13:22:37 +0200 Peter Zijlstra wrote: > On Thu, Oct 03, 2019 at 06:10:45PM -0400, Steven Rostedt wrote: > > But still, we are going from 120 to 660 IPIs for every CPU. Not saying > > it's a problem, but something that we should note. Someone (those that > > don't like kernel interference) may complain. > > It is machine wide function tracing, interference is going to happen.. > :-) > > Anyway, we can grow the batch size if sufficient benefit can be shown to > exist. Yeah, I was thinking that we just go with these patches and then fix the IPI issue when someone starts complaining ;-) Anyway, is this series ready to go? I can pull them in (I guess I should get an ack from Thomas or Ingo as they are x86 specific). I'm currently working on code that affects the same code paths as this patch, and would like to build my changes on top of this, instead of monkeying around with major conflicts. -- Steve