From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B682C4360C for ; Fri, 4 Oct 2019 10:59:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1283020867 for ; Fri, 4 Oct 2019 10:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387537AbfJDK7m (ORCPT ); Fri, 4 Oct 2019 06:59:42 -0400 Received: from retiisi.org.uk ([95.216.213.190]:52746 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726082AbfJDK7m (ORCPT ); Fri, 4 Oct 2019 06:59:42 -0400 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 59937634C87; Fri, 4 Oct 2019 13:59:04 +0300 (EEST) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1iGLIc-0002PR-Nb; Fri, 04 Oct 2019 13:59:02 +0300 Date: Fri, 4 Oct 2019 13:59:02 +0300 From: Sakari Ailus To: Manivannan Sadhasivam Cc: mchehab@kernel.org, robh+dt@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, c.barrett@framos.com, a.brela@framos.com Subject: Re: [PATCH v4 2/2] media: i2c: Add IMX290 CMOS image sensor driver Message-ID: <20191004105902.GM896@valkosipuli.retiisi.org.uk> References: <20191003095503.12614-1-manivannan.sadhasivam@linaro.org> <20191003095503.12614-3-manivannan.sadhasivam@linaro.org> <20191004092336.GL896@valkosipuli.retiisi.org.uk> <20191004101902.GA19685@mani> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191004101902.GA19685@mani> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Manivannan, On Fri, Oct 04, 2019 at 03:49:02PM +0530, Manivannan Sadhasivam wrote: > Hi Sakari, > > On Fri, Oct 04, 2019 at 12:23:36PM +0300, Sakari Ailus wrote: > > Hi Manivannan, > > > > On Thu, Oct 03, 2019 at 03:25:03PM +0530, Manivannan Sadhasivam wrote: > > > Add driver for Sony IMX290 CMOS image sensor driver. The driver only > > > supports I2C interface for programming and MIPI CSI-2 for sensor output. > > > > > > Signed-off-by: Manivannan Sadhasivam > > > > Could you remove the unneeded ret variable from imx290_power_on() and > > unneeded goto in the same function? > > > > yep, sure. > > > The MAINTAINERS entry belongs to the first patch adding new files. > > > > You mean the bindings patch? If then, sorry no. Usually the devicetree bindings > belongs to a separate patch and that is what perferred by Rob. I prefer the > MAINTAINERS entry in a separate patch but I've seen subsystems maintainers > asking to squash it with the driver patch. But squashing it with bindings > patch seems weird to me. This has been an established practice at least in the media tree. The MAINTAINERS change is small, and bindings come before the driver. And the MAINTAINERS change needs to come no later than files are being added, or a checkpatch.pl warning follows --- which is entirely reasonable. You could put the MAINTAINERS change to a separate patch, yes, but I personally think it fits fine with the DT binding patch. -- Regards, Sakari Ailus