From: Christian Brauner <christian.brauner@ubuntu.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Will Deacon <will@kernel.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Amir Goldstein <amir73il@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Varad Gautam <vrd@amazon.de>,
stable@vger.kernel.org, Jan Glauber <jglauber@marvell.com>
Subject: Re: [PATCH] devpts: Fix NULL pointer dereference in dcache_readdir()
Date: Fri, 4 Oct 2019 16:33:02 +0200 [thread overview]
Message-ID: <20191004143301.kfzcut6a6z5owfee@wittgenstein> (raw)
In-Reply-To: <20191004142748.GG26530@ZenIV.linux.org.uk>
On Fri, Oct 04, 2019 at 03:27:48PM +0100, Al Viro wrote:
> On Fri, Oct 04, 2019 at 04:05:03PM +0200, Christian Brauner wrote:
> > From: Will Deacon <will@kernel.org>
> >
> > Closing /dev/pts/ptmx removes the corresponding pty under /dev/pts/
> > without synchronizing against concurrent path walkers. This can lead to
> > 'dcache_readdir()' tripping over a 'struct dentry' with a NULL 'd_inode'
> > field:
>
> FWIW, vfs.git#fixes (or #next.dcache) ought to deal with that one.
Is it feasible to backport your changes? Or do we want to merge the one
here first and backport?
Christian
next prev parent reply other threads:[~2019-10-04 14:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 14:05 Christian Brauner
2019-10-04 14:27 ` Al Viro
2019-10-04 14:33 ` Christian Brauner [this message]
2019-10-04 15:10 ` Al Viro
2019-10-04 15:25 ` Christian Brauner
2019-10-04 16:02 ` Al Viro
2019-10-04 16:54 ` [cifs] semantics of IPC$ shares (was Re: [PATCH] devpts: Fix NULL pointer dereference in dcache_readdir()) Al Viro
2019-10-05 2:04 ` Steve French
2019-10-04 16:52 ` [PATCH] devpts: Fix NULL pointer dereference in dcache_readdir() Linus Torvalds
2019-10-04 16:54 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004143301.kfzcut6a6z5owfee@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=amir73il@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jglauber@marvell.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vrd@amazon.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®