From: Hans de Goede <hdegoede@redhat.com>
To: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-usb@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] usb: dwc3: Remove dev_err() on platform_get_irq() failure
Date: Sat, 5 Oct 2019 23:04:49 +0200 [thread overview]
Message-ID: <20191005210449.3926-4-hdegoede@redhat.com> (raw)
In-Reply-To: <20191005210449.3926-1-hdegoede@redhat.com>
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to
platform_get_irq*()"), platform_get_irq() will call dev_err() itself on
failure, so there is no need for the driver to also do this.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/usb/dwc3/drd.c | 3 ---
drivers/usb/dwc3/gadget.c | 3 ---
drivers/usb/dwc3/host.c | 3 ---
3 files changed, 9 deletions(-)
diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
index b1f76628b313..c946d64142ad 100644
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -157,9 +157,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc)
if (irq > 0)
goto out;
- if (irq != -EPROBE_DEFER)
- dev_err(dwc->dev, "missing OTG IRQ\n");
-
if (!irq)
irq = -EINVAL;
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 13c97ff21dba..86dc1db788a9 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -3282,9 +3282,6 @@ static int dwc3_gadget_get_irq(struct dwc3 *dwc)
if (irq > 0)
goto out;
- if (irq != -EPROBE_DEFER)
- dev_err(dwc->dev, "missing peripheral IRQ\n");
-
if (!irq)
irq = -EINVAL;
diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index 534a49609779..5567ed2cddbe 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -34,9 +34,6 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
if (irq > 0)
goto out;
- if (irq != -EPROBE_DEFER)
- dev_err(dwc->dev, "missing host IRQ\n");
-
if (!irq)
irq = -EINVAL;
--
2.23.0
next prev parent reply other threads:[~2019-10-05 21:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 21:04 [PATCH 0/3] Add platform_get_irq_byname_optional() and use it in the dwc3 driver Hans de Goede
2019-10-05 21:04 ` [PATCH 1/3] driver core: platform: Add platform_get_irq_byname_optional() Hans de Goede
2019-10-07 8:53 ` Rafael J. Wysocki
2019-10-07 15:30 ` Stephen Boyd
2019-10-05 21:04 ` [PATCH 2/3] usb: dwc3: Switch to platform_get_irq_byname_optional() Hans de Goede
2019-10-07 5:38 ` Felipe Balbi
2019-10-07 15:31 ` Stephen Boyd
2019-10-05 21:04 ` Hans de Goede [this message]
2019-10-07 5:39 ` [PATCH 3/3] usb: dwc3: Remove dev_err() on platform_get_irq() failure Felipe Balbi
2019-10-07 15:31 ` Stephen Boyd
2019-10-07 10:54 ` [PATCH 0/3] Add platform_get_irq_byname_optional() and use it in the dwc3 driver Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005210449.3926-4-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®