From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCDC9C4360C for ; Sun, 6 Oct 2019 15:32:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90C0C2080F for ; Sun, 6 Oct 2019 15:32:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=rere.qmqm.pl header.i=@rere.qmqm.pl header.b="mhOoTq3x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726508AbfJFPcH (ORCPT ); Sun, 6 Oct 2019 11:32:07 -0400 Received: from rere.qmqm.pl ([91.227.64.183]:41275 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726245AbfJFPcH (ORCPT ); Sun, 6 Oct 2019 11:32:07 -0400 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 46mSGf3048z4p; Sun, 6 Oct 2019 17:30:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1570375806; bh=gGVpWXK4iH8c96Sf0pNYq0Jcb/h2p6O0QCA4k6ZIcko=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mhOoTq3xIXpWE/BsUeYXIYA/6A3LtWCsoA++ru0/dvV+bWcrvjYkrbQVfj7TD+JOv tdQT9OmGNubwR+1gti4hT/7zx0jnny5tqQnHBL1RSOnIP1wmrg/mrRqutjSHb78Ww+ a/UiYvR31pnMvb2kv7ufbdxFxPq47zpZIzbG3/CrNFiyMxF4Lk0s+BnWNkQlZXUkKt HVGdLttY6UbYkoseX+HbC/AUT44b30RsGyKQYjElIBkkR868Jfi4QB2XqztE3L4NMO LUm/xe228Eld5UgTpMAn4nczOoqnKOV1pxfh/0n5ZFcnX/pspP9fHz9S+uKbeiSMfR IoGF/7IKIwUnw== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.101.4 at mail Date: Sun, 6 Oct 2019 17:31:58 +0200 From: mirq-linux@rere.qmqm.pl To: YueHaibing Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, ckeepax@opensource.cirrus.com, rf@opensource.wolfsonmicro.com, piotrs@opensource.cirrus.com, enric.balletbo@collabora.com, paul@crapouillou.net, srinivas.kandagatla@linaro.org, andradanciu1997@gmail.com, kuninori.morimoto.gx@renesas.com, m.felsch@pengutronix.de, shifu0704@thundersoft.com, ladis@linux-mips.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 -next] ASoc: tas2770: Fix build error without GPIOLIB Message-ID: <20191006153158.GA9882@qmqm.qmqm.pl> References: <20191006072241.56808-1-yuehaibing@huawei.com> <20191006104631.60608-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191006104631.60608-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 06, 2019 at 06:46:31PM +0800, YueHaibing wrote: > If GPIOLIB is not set, building fails: > > sound/soc/codecs/tas2770.c: In function tas2770_reset: > sound/soc/codecs/tas2770.c:38:3: error: implicit declaration of function gpiod_set_value_cansleep; did you mean gpio_set_value_cansleep? [-Werror=implicit-function-declaration] > gpiod_set_value_cansleep(tas2770->reset_gpio, 0); > ^~~~~~~~~~~~~~~~~~~~~~~~ > gpio_set_value_cansleep > sound/soc/codecs/tas2770.c: In function tas2770_i2c_probe: > sound/soc/codecs/tas2770.c:749:24: error: implicit declaration of function devm_gpiod_get_optional; did you mean devm_regulator_get_optional? [-Werror=implicit-function-declaration] > tas2770->reset_gpio = devm_gpiod_get_optional(tas2770->dev, > ^~~~~~~~~~~~~~~~~~~~~~~ > devm_regulator_get_optional > sound/soc/codecs/tas2770.c:751:13: error: GPIOD_OUT_HIGH undeclared (first use in this function); did you mean GPIOF_INIT_HIGH? > GPIOD_OUT_HIGH); > ^~~~~~~~~~~~~~ > GPIOF_INIT_HIGH > > Reported-by: Hulk Robot > Fixes: 1a476abc723e ("tas2770: add tas2770 smart PA kernel driver") > Suggested-by: Ladislav Michl > Signed-off-by: YueHaibing > --- > v2: Add missing include file > --- > sound/soc/codecs/tas2770.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c > index 9da88cc..a36d0d7 100644 > --- a/sound/soc/codecs/tas2770.c > +++ b/sound/soc/codecs/tas2770.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include The Kconfig part is missing - is this intended? If I guess correctly, the driver won't work without GPIOLIB, so it should either 'select GPIOLIB' or 'depends on GPIOLIB || COMPILE_TEST' or even 'select GPIOLIB if !COMPILE_TEST'. Best Regards, Michał Mirosław