From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: outreachy@googlegroups.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, abbotti@mev.co.uk,
olsonse@umich.edu
Subject: Re: [PATCH] staging: comedi: Fix camelcase check warning
Date: Sun, 6 Oct 2019 21:08:35 +0200 [thread overview]
Message-ID: <20191006190835.GC237538@kroah.com> (raw)
In-Reply-To: <20191006184453.11765-1-jbi.octave@gmail.com>
On Sun, Oct 06, 2019 at 07:44:53PM +0100, Jules Irenge wrote:
> Capitalize unit_ma to fix camelcase check warning.
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/comedi/comedi.h | 4 ++--
> drivers/staging/comedi/comedidev.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 09a940066c0e..df770043b37d 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -674,7 +674,7 @@ struct comedi_rangeinfo {
> * linear (for the purpose of describing the range), with sample value %0
> * mapping to @min, and the 'maxdata' sample value mapping to @max.
> *
> - * The currently defined units are %UNIT_volt (%0), %UNIT_mA (%1), and
> + * The currently defined units are %UNIT_volt (%0), %UNIT_MA (%1), and
> * %UNIT_none (%2). The @min and @max values are the physical range multiplied
> * by 1e6, so a @max value of %1000000 (with %UNIT_volt) represents a maximal
> * value of 1 volt.
> @@ -909,7 +909,7 @@ struct comedi_bufinfo {
> #define RF_EXTERNAL 0x100
>
> #define UNIT_volt 0
> -#define UNIT_mA 1
> +#define UNIT_MA 1
Sorry, but "mA" is a unit of measurement of power, and needs to stay
as-is.
thanks,
greg k-h
prev parent reply other threads:[~2019-10-06 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 18:44 Jules Irenge
2019-10-06 19:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006190835.GC237538@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=jbi.octave@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olsonse@umich.edu \
--cc=outreachy@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome