From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C6C9C4740A for ; Mon, 7 Oct 2019 08:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C2C92133F for ; Mon, 7 Oct 2019 08:03:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727483AbfJGIDZ (ORCPT ); Mon, 7 Oct 2019 04:03:25 -0400 Received: from mga01.intel.com ([192.55.52.88]:38910 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726889AbfJGIDZ (ORCPT ); Mon, 7 Oct 2019 04:03:25 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 01:03:24 -0700 X-IronPort-AV: E=Sophos;i="5.67,265,1566889200"; d="scan'208";a="344666799" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 01:03:22 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 46DD920B1D; Mon, 7 Oct 2019 11:03:20 +0300 (EEST) Date: Mon, 7 Oct 2019 11:03:20 +0300 From: Sakari Ailus To: Benoit Parrot Cc: Hans Verkuil , Jacopo Mondi , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 1/3] media: ov5640: add PIXEL_RATE control Message-ID: <20191007080320.GG14917@paasikivi.fi.intel.com> References: <20191004172418.2339-1-bparrot@ti.com> <20191004172418.2339-2-bparrot@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191004172418.2339-2-bparrot@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 04, 2019 at 12:24:16PM -0500, Benoit Parrot wrote: > @@ -2657,6 +2669,12 @@ static int ov5640_init_controls(struct ov5640_dev *sensor) > /* we can use our own mutex for the ctrl lock */ > hdl->lock = &sensor->lock; > > + /* Clock related controls */ > + ctrls->pixel_rate = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_PIXEL_RATE, > + 0, INT_MAX, 1, > + ov5640_calc_pixel_rate(sensor)); > + ctrls->pixel_rate->flags |= V4L2_CTRL_FLAG_READ_ONLY; Please check ctrls->pixel_rate first; it may be NULL here. > + > /* Auto/manual white balance */ > ctrls->auto_wb = v4l2_ctrl_new_std(hdl, ops, > V4L2_CID_AUTO_WHITE_BALANCE, -- Sakari Ailus sakari.ailus@linux.intel.com