From: Steven Rostedt <rostedt@goodmis.org>
To: Marco Elver <elver@google.com>
Cc: syzbot <syzbot+134336b86f728d6e55a0@syzkaller.appspotmail.com>,
paulmck@kernel.org, josh@joshtriplett.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
Joel Fernandes <joel@joelfernandes.org>,
rcu@vger.kernel.org, a@unstable.cc,
b.a.t.m.a.n@lists.open-mesh.org, davem@davemloft.net,
LKML <linux-kernel@vger.kernel.org>,
mareklindner@neomailbox.ch, netdev@vger.kernel.org,
sw@simonwunderlich.de, syzkaller-bugs@googlegroups.com
Subject: Re: KCSAN: data-race in find_next_bit / rcu_report_exp_cpu_mult
Date: Mon, 7 Oct 2019 09:34:53 -0400 [thread overview]
Message-ID: <20191007093453.2d9852ce@gandalf.local.home> (raw)
In-Reply-To: <CANpmjNNmSOagbTpffHr4=Yedckx9Rm2NuGqC9UqE+AOz5f1-ZQ@mail.gmail.com>
On Mon, 7 Oct 2019 12:04:16 +0200
Marco Elver <elver@google.com> wrote:
> +RCU maintainers
> This might be a data-race in RCU itself.
>
> >
> > write to 0xffffffff85a7f140 of 8 bytes by task 7 on cpu 0:
> > rcu_report_exp_cpu_mult+0x4f/0xa0 kernel/rcu/tree_exp.h:244
Here we have:
raw_spin_lock_irqsave_rcu_node(rnp, flags);
if (!(rnp->expmask & mask)) {
raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
return;
}
rnp->expmask &= ~mask;
__rcu_report_exp_rnp(rnp, wake, flags); /* Releases rnp->lock. */
> >
> > read to 0xffffffff85a7f140 of 8 bytes by task 7251 on cpu 1:
> > _find_next_bit lib/find_bit.c:39 [inline]
> > find_next_bit+0x57/0xe0 lib/find_bit.c:70
> > sync_rcu_exp_select_node_cpus+0x28e/0x510 kernel/rcu/tree_exp.h:375
and here we have:
raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
/* IPI the remaining CPUs for expedited quiescent state. */
for_each_leaf_node_cpu_mask(rnp, cpu, rnp->expmask) {
The write to rnp->expmask is done under the rnp->lock, but on the read
side, that lock is released before the for loop. Should we have
something like:
unsigned long expmask;
[...]
expmask = rnp->expmask;
raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
/* IPI the remaining CPUs for expedited quiescent state. */
for_each_leaf_node_cpu_mask(rnp, cpu, expmask) {
?
-- Steve
next prev parent reply other threads:[~2019-10-07 13:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 10:01 syzbot
2019-10-07 10:04 ` Marco Elver
2019-10-07 13:22 ` Paul E. McKenney
2019-10-07 13:34 ` Steven Rostedt [this message]
2019-10-07 13:43 ` Boqun Feng
2019-10-08 0:11 ` Joel Fernandes
2019-10-08 2:12 ` Paul E. McKenney
2019-10-08 2:50 ` Boqun Feng
2019-10-08 3:33 ` Paul E. McKenney
2019-10-08 3:58 ` Boqun Feng
2019-10-08 1:47 ` Paul E. McKenney
2020-01-25 10:42 ` [tip: core/rcu] rcu: Use *_ONCE() to protect lockless ->expmask accesses tip-bot2 for Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007093453.2d9852ce@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=elver@google.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=mathieu.desnoyers@efficios.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=sw@simonwunderlich.de \
--cc=syzbot+134336b86f728d6e55a0@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®