From: Dan Murphy <dmurphy@ti.com>
To: <shifu0704@thundersoft.com>, <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>, <navada@ti.com>, <perex@perex.cz>,
<tiwai@suse.com>, Dan Murphy <dmurphy@ti.com>
Subject: [PATCH v2 2/3] ASoC: tas2770: Remove unneeded read of the TDM_CFG3 register
Date: Mon, 7 Oct 2019 12:11:56 -0500 [thread overview]
Message-ID: <20191007171157.17813-2-dmurphy@ti.com> (raw)
In-Reply-To: <20191007171157.17813-1-dmurphy@ti.com>
Remove the unneeded and incorrect read of the TDM_CFG3 register.
The read is done but the value is never used.
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
v2 - New patch no v1
sound/soc/codecs/tas2770.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c
index 361d0bba72b3..c1e28dd0b73e 100644
--- a/sound/soc/codecs/tas2770.c
+++ b/sound/soc/codecs/tas2770.c
@@ -386,7 +386,6 @@ static int tas2770_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
{
u8 tdm_rx_start_slot = 0, asi_cfg_1 = 0;
int ret;
- int value = 0;
struct snd_soc_component *component = dai->component;
struct tas2770_priv *tas2770 =
snd_soc_component_get_drvdata(component);
@@ -442,8 +441,6 @@ static int tas2770_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
if (ret < 0)
return ret;
- value = snd_soc_component_read32(component, TAS2770_TDM_CFG_REG3);
-
tas2770->asi_format = fmt;
return 0;
--
2.22.0.214.g8dca754b1e
next prev parent reply other threads:[~2019-10-07 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 17:11 [PATCH v2 1/3] ASoC: tas2770: Fix snd_soc_update_bits error handling Dan Murphy
2019-10-07 17:11 ` Dan Murphy [this message]
2019-10-07 18:13 ` Applied "ASoC: tas2770: Remove unneeded read of the TDM_CFG3 register" to the asoc tree Mark Brown
2019-10-07 17:11 ` [PATCH v2 3/3] ASoc: tas2770: Remove unused defines and variables Dan Murphy
2019-10-07 18:13 ` Applied "ASoc: tas2770: Remove unused defines and variables" to the asoc tree Mark Brown
2019-10-07 18:13 ` Applied "ASoC: tas2770: Fix snd_soc_update_bits error handling" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007171157.17813-2-dmurphy@ti.com \
--to=dmurphy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=perex@perex.cz \
--cc=shifu0704@thundersoft.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome