From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADF3BC10F14 for ; Tue, 8 Oct 2019 12:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CADC2070B for ; Tue, 8 Oct 2019 12:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730871AbfJHMEM (ORCPT ); Tue, 8 Oct 2019 08:04:12 -0400 Received: from 20.mo3.mail-out.ovh.net ([178.33.47.94]:57428 "EHLO 20.mo3.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730729AbfJHMEJ (ORCPT ); Tue, 8 Oct 2019 08:04:09 -0400 Received: from player688.ha.ovh.net (unknown [10.108.54.72]) by mo3.mail-out.ovh.net (Postfix) with ESMTP id 504E0221A4E for ; Tue, 8 Oct 2019 13:44:15 +0200 (CEST) Received: from etezian.org (85-76-98-218-nat.elisa-mobile.fi [85.76.98.218]) (Authenticated sender: andi@etezian.org) by player688.ha.ovh.net (Postfix) with ESMTPSA id CF780AA08234; Tue, 8 Oct 2019 11:44:04 +0000 (UTC) Date: Tue, 8 Oct 2019 14:44:03 +0300 From: Andi Shyti To: Andi Shyti Cc: Stephan Gerhold , Dmitry Torokhov , Simon Shields , linux-input@vger.kernel.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] Input: mms114 - add support for mms345l Message-ID: <20191008114403.GB4015@jack.zhora.eu> References: <20191007203343.101466-1-stephan@gerhold.net> <20191007205021.104402-1-stephan@gerhold.net> <20191008113511.GA4015@jack.zhora.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191008113511.GA4015@jack.zhora.eu> User-Agent: Mutt/1.10.1 (2018-07-13) X-Ovh-Tracer-Id: 8543047019269243586 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -85 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrheelgdeghecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenogetfedtuddqtdduucdludehmd Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > - if (!i2c_check_functionality(client->adapter, > > - I2C_FUNC_PROTOCOL_MANGLING)) { > > + type = (enum mms_type)device_get_match_data(&client->dev); > > you don't need any cast here. sorry, please ignore :) Andi