mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arvind Sankar <nivedita@alum.mit.edu>
To: Christoph Hellwig <hch@lst.de>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
	Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2
Date: Tue, 8 Oct 2019 07:51:03 -0400	[thread overview]
Message-ID: <20191008115103.GA463127@rani.riverdale.lan> (raw)
In-Reply-To: <20191008073210.GB9452@lst.de>

On Tue, Oct 08, 2019 at 09:32:10AM +0200, Christoph Hellwig wrote:
> On Mon, Oct 07, 2019 at 07:54:02PM -0400, Arvind Sankar wrote:
> > > Do you want me to resend the patch as its own mail, or do you just take
> > > it with a Tested-by: from me? If the former, I assume you're ok with me
> > > adding your Signed-off-by?
> > > 
> > > Thanks
> > 
> > A question on the original change though -- what happens if a single
> > device (or a single IOMMU domain really) does want >4G DMA address
> > space? Was that not previously allowed either?
> 
> Your EHCI device actually supports the larger addressing.  Without an
> IOMMU (or with accidentally enabled passthrough mode as in your report)
> that will use bounce buffers for physical address that are too large.
> With an iommu we can just remap, and by default those remap addresses
> are under 32-bit just to make everyones life easier.
> 
> The dma_get_required_mask function is misnamed unfortunately, what it
> really means is the optimal mask, that is one that avoids bounce
> buffering or other complications.

I understand that my EHCI device, even though it only supports 32-bit
adddressing, will be able to DMA into anywhere in physical RAM, whether
below 4G or not, via the IOMMU or bounce buffering.

What I mean is, do there exist devices (which would necessarily support
64-bit DMA) that want to DMA using bigger than 4Gb buffers. Eg a GPU
accelerator card with 16Gb of RAM on-board that wants to map 6Gb for DMA
in one go, or 5 accelerator cards that are in one IOMMU domain and want
to simultaneously map 1Gb each.

  reply	other threads:[~2019-10-08 11:51 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07  2:24 Arvind Sankar
2019-10-07  7:34 ` Christoph Hellwig
2019-10-07 17:54   ` Arvind Sankar
2019-10-07 17:55     ` Christoph Hellwig
2019-10-07 17:56       ` Christoph Hellwig
2019-10-07 17:58         ` Arvind Sankar
2019-10-07 18:32           ` Arvind Sankar
2019-10-07 18:47             ` Christoph Hellwig
2019-10-07 22:10               ` Arvind Sankar
2019-10-07 23:54                 ` Arvind Sankar
2019-10-08  7:32                   ` Christoph Hellwig
2019-10-08 11:51                     ` Arvind Sankar [this message]
2019-10-08 12:50                       ` Christoph Hellwig
2019-10-08 15:47                       ` Arvind Sankar
2019-10-09  6:50                         ` Christoph Hellwig
2019-10-09 13:48                           ` Arvind Sankar
2019-10-08  7:29                 ` Christoph Hellwig
2019-10-08 14:33                   ` [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU Arvind Sankar
2019-10-09  2:45                     ` Lu Baolu
2019-10-09  6:51                       ` Christoph Hellwig
2019-10-10  1:24                         ` Lu Baolu
2019-10-10  1:26                     ` Lu Baolu
2019-10-16 19:15                       ` Arvind Sankar
2019-10-17  7:08                         ` Christoph Hellwig
2019-10-17 15:55                           ` Arvind Sankar
2019-10-18  9:50                           ` Joerg Roedel
2019-10-18 15:14                             ` Christoph Hellwig
2019-10-18 15:21                               ` Joerg Roedel
2019-10-18 15:22                                 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008115103.GA463127@rani.riverdale.lan \
    --to=nivedita@alum.mit.edu \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®