mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Jason Wessel <jason.wessel@windriver.com>,
	Douglas Anderson <dianders@chromium.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
	kgdb-bugreport@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, patches@linaro.org
Subject: [PATCH v2 0/5] kdb: Cleanup code to read user input and handle escape sequences
Date: Tue,  8 Oct 2019 14:20:38 +0100	[thread overview]
Message-ID: <20191008132043.7966-1-daniel.thompson@linaro.org> (raw)

I've been meaning to repost this for some time, and inspired by
having someone keen to review it, I dug it out again!

I split this as carefully as I could into small pieces but the original
code was complex so even in small bits it doesn't make for light
reading.  Things do make more sense once you realize/remember that
escape_delay is a count down timer that expires the escape sequences!

Most of the patches are simple tidy ups although patches 4 and 5
introduce new behaviours. Patch 4 shouldn't be controversial but
perhaps patch 5 is (although hopefully not ;-) ).

Mostly this is auto tested, see here:
https://github.com/daniel-thompson/kgdbtest/commit/c65e28d99357c2df6dac2cebe195574e634d04dc

Changes in v2:

 - Improve comment in patch 4 to better describe what is happening
 - Rebase on v5.4-rc2

Daniel Thompson (5):
  kdb: Tidy up code to handle escape sequences
  kdb: Simplify code to fetch characters from console
  kdb: Remove special case logic from kdb_read()
  kdb: Improve handling of characters from different input sources
  kdb: Tweak escape handling for vi users

 kernel/debug/kdb/kdb_io.c | 222 ++++++++++++++++++--------------------
 1 file changed, 103 insertions(+), 119 deletions(-)

--
2.21.0


             reply	other threads:[~2019-10-08 13:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08 13:20 Daniel Thompson [this message]
2019-10-08 13:20 ` [PATCH v2 1/5] kdb: Tidy up code to " Daniel Thompson
2019-10-08 22:20   ` Doug Anderson
2019-10-08 13:20 ` [PATCH v2 2/5] kdb: Simplify code to fetch characters from console Daniel Thompson
2019-10-08 22:20   ` Doug Anderson
2019-10-08 13:20 ` [PATCH v2 3/5] kdb: Remove special case logic from kdb_read() Daniel Thompson
2019-10-08 22:21   ` Doug Anderson
2019-10-09  9:30     ` Daniel Thompson
2019-10-09 17:28       ` Doug Anderson
2019-10-10  9:50         ` Daniel Thompson
2019-10-08 13:20 ` [PATCH v2 4/5] kdb: Improve handling of characters from different input sources Daniel Thompson
2019-10-08 22:21   ` Doug Anderson
2019-10-08 13:20 ` [PATCH v2 5/5] kdb: Tweak escape handling for vi users Daniel Thompson
2019-10-08 22:21   ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008132043.7966-1-daniel.thompson@linaro.org \
    --to=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=jason.wessel@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®