From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B4BECE58C for ; Tue, 8 Oct 2019 16:54:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B62C2070B for ; Tue, 8 Oct 2019 16:54:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727180AbfJHQyw (ORCPT ); Tue, 8 Oct 2019 12:54:52 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:51365 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbfJHQyw (ORCPT ); Tue, 8 Oct 2019 12:54:52 -0400 Received: from localhost (aclermont-ferrand-651-1-259-53.w86-207.abo.wanadoo.fr [86.207.98.53]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 4886D240003; Tue, 8 Oct 2019 16:54:50 +0000 (UTC) Date: Tue, 8 Oct 2019 18:54:49 +0200 From: Alexandre Belloni To: Claudiu Beznea Cc: mturquette@baylibre.com, sboyd@kernel.org, nicolas.ferre@microchip.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: at91: add compatible for sam9x60 Message-ID: <20191008165449.GA4254@piout.net> References: <1570553186-24691-1-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1570553186-24691-1-git-send-email-claudiu.beznea@microchip.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/10/2019 19:46:26+0300, Claudiu Beznea wrote: > Add compatible for SAM9X60's PMC. I think the commit log could be clearer and mention why this is needed and the compatible string in sam9x60 is not sufficient. > > Signed-off-by: Claudiu Beznea > --- > drivers/clk/at91/pmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c > index db24539d5740..24975bca608e 100644 > --- a/drivers/clk/at91/pmc.c > +++ b/drivers/clk/at91/pmc.c > @@ -271,6 +271,7 @@ static struct syscore_ops pmc_syscore_ops = { > > static const struct of_device_id sama5d2_pmc_dt_ids[] = { Maybe rename the array? > { .compatible = "atmel,sama5d2-pmc" }, > + { .compatible = "microchip,sam9x60-pmc" }, > { /* sentinel */ } > }; > > -- > 2.7.4 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com