From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87ED5C47404 for ; Wed, 9 Oct 2019 08:16:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B8C720B7C for ; Wed, 9 Oct 2019 08:16:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="eVlJScwC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729820AbfJIIQy (ORCPT ); Wed, 9 Oct 2019 04:16:54 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:33016 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbfJIIQx (ORCPT ); Wed, 9 Oct 2019 04:16:53 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C16264FF; Wed, 9 Oct 2019 10:16:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1570609011; bh=dfCYYmVUWtdv4zBsKgd4ZyXxFLnPVhNwwZgG6/vSvNg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eVlJScwCub0+GmlR5SL43r9WCQGHvo9eM6c3APruewM0PbYssfq970wql++ufnvrm IEgxyFr9psKDOwHspLVplOYzuPu0y7Z2YECA8WMOwNtwWgwBfXoF2kgdWWUaVSsdKz C1trqy9ctIwsYWPhlB9Hmh24hDRxkzWbPMSNiF9w= Date: Wed, 9 Oct 2019 11:16:48 +0300 From: Laurent Pinchart To: Wolfram Sang Cc: dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] gpu: drm: bridge: sii9234: convert to devm_i2c_new_dummy_device Message-ID: <20191009081648.GC22998@pendragon.ideasonboard.com> References: <20191008203322.3238-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191008203322.3238-1-wsa+renesas@sang-engineering.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, Thank you for the patch. On Tue, Oct 08, 2019 at 10:33:22PM +0200, Wolfram Sang wrote: > Move from the deprecated i2c_new_dummy() to devm_i2c_new_dummy_device(). > We now get an ERRPTR which we use in error handling and we can skip > removal of the created devices. > > Signed-off-by: Wolfram Sang Reviewed-by: Laurent Pinchart > --- > > Rebased to v5.4-rc2 since last time. One of the last two users of the > old API, so please apply soon, so I can remove the old interface. Only > build tested. > > drivers/gpu/drm/bridge/sii9234.c | 36 +++++++++++--------------------- > 1 file changed, 12 insertions(+), 24 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c > index 25d4ad8c7ad6..8a6c85693a88 100644 > --- a/drivers/gpu/drm/bridge/sii9234.c > +++ b/drivers/gpu/drm/bridge/sii9234.c > @@ -841,39 +841,28 @@ static int sii9234_init_resources(struct sii9234 *ctx, > > ctx->client[I2C_MHL] = client; > > - ctx->client[I2C_TPI] = i2c_new_dummy(adapter, I2C_TPI_ADDR); > - if (!ctx->client[I2C_TPI]) { > + ctx->client[I2C_TPI] = devm_i2c_new_dummy_device(&client->dev, adapter, > + I2C_TPI_ADDR); > + if (IS_ERR(ctx->client[I2C_TPI])) { > dev_err(ctx->dev, "failed to create TPI client\n"); > - return -ENODEV; > + return PTR_ERR(ctx->client[I2C_TPI]); > } > > - ctx->client[I2C_HDMI] = i2c_new_dummy(adapter, I2C_HDMI_ADDR); > - if (!ctx->client[I2C_HDMI]) { > + ctx->client[I2C_HDMI] = devm_i2c_new_dummy_device(&client->dev, adapter, > + I2C_HDMI_ADDR); > + if (IS_ERR(ctx->client[I2C_HDMI])) { > dev_err(ctx->dev, "failed to create HDMI RX client\n"); > - goto fail_tpi; > + return PTR_ERR(ctx->client[I2C_HDMI]); > } > > - ctx->client[I2C_CBUS] = i2c_new_dummy(adapter, I2C_CBUS_ADDR); > - if (!ctx->client[I2C_CBUS]) { > + ctx->client[I2C_CBUS] = devm_i2c_new_dummy_device(&client->dev, adapter, > + I2C_CBUS_ADDR); > + if (IS_ERR(ctx->client[I2C_CBUS])) { > dev_err(ctx->dev, "failed to create CBUS client\n"); > - goto fail_hdmi; > + return PTR_ERR(ctx->client[I2C_CBUS]); > } > > return 0; > - > -fail_hdmi: > - i2c_unregister_device(ctx->client[I2C_HDMI]); > -fail_tpi: > - i2c_unregister_device(ctx->client[I2C_TPI]); > - > - return -ENODEV; > -} > - > -static void sii9234_deinit_resources(struct sii9234 *ctx) > -{ > - i2c_unregister_device(ctx->client[I2C_CBUS]); > - i2c_unregister_device(ctx->client[I2C_HDMI]); > - i2c_unregister_device(ctx->client[I2C_TPI]); > } > > static inline struct sii9234 *bridge_to_sii9234(struct drm_bridge *bridge) > @@ -950,7 +939,6 @@ static int sii9234_remove(struct i2c_client *client) > > sii9234_cable_out(ctx); > drm_bridge_remove(&ctx->bridge); > - sii9234_deinit_resources(ctx); > > return 0; > } -- Regards, Laurent Pinchart