From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64EBEC4360C for ; Thu, 10 Oct 2019 21:55:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 367F3206B6 for ; Thu, 10 Oct 2019 21:55:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727300AbfJJVzi (ORCPT ); Thu, 10 Oct 2019 17:55:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:41972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbfJJVzh (ORCPT ); Thu, 10 Oct 2019 17:55:37 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA16D2067B; Thu, 10 Oct 2019 21:55:36 +0000 (UTC) Date: Thu, 10 Oct 2019 17:55:35 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: LKML , Ingo Molnar , Peter Zijlstra , "H. Peter Anvin" , Thomas Gleixner , Andrew Morton Subject: Re: [RFC][PATCH] kprobes/x86: While list ftrace locations in kprobe blacklist areas Message-ID: <20191010175535.0a69941b@gandalf.local.home> In-Reply-To: <20191010175216.4ceb3cf1@gandalf.local.home> References: <20191010175216.4ceb3cf1@gandalf.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Oct 2019 17:52:16 -0400 Steven Rostedt wrote: > I noticed some of my old tests failing on kprobes, and realized that > this was due to black listing irq_entry functions on x86 from being > used by kprobes. IIRC, this was due to the cr2 being corrupted and > such, and I believe other things were to cause. But black listing all > irq_entry code is a big hammer to this. > > (See commit 0eae81dc9f026 "x86/kprobes: Prohibit probing on IRQ > handlers directly" for more details) BTW, I noticed this recently (again) when running my tests by hand. I forgot that I have my automated tests revert the above commit before compiling the kernel it is about to test (because it tests kprobes on irq entry locations!). My tests never had issues with kprobes on irq entry locations. -- Steve