From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D4A2ECE58C for ; Fri, 11 Oct 2019 12:08:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6496C21A4A for ; Fri, 11 Oct 2019 12:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570795731; bh=7CIPFLIoZZluL3rWipgb8S80+pXhDenVx59NnSIkLzI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=POz+0zjhVzKRnIMLb69+31fQVkzH5XicBjCDvDJpNGUjpXq9pJHFqlB7fNHSuFthT LGkDQJm1Hak0+1QP6eJdoX6vR16LuzkPBXnLL71tDrFt1TNe+xluYacLAio+x6tX7z ZScQ3HriN/pEtFoUo1caKC1ZrJPeThw1dBSC1Tvg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727986AbfJKMIu (ORCPT ); Fri, 11 Oct 2019 08:08:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:55724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727198AbfJKMIu (ORCPT ); Fri, 11 Oct 2019 08:08:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 009CE214E0; Fri, 11 Oct 2019 12:08:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570795729; bh=7CIPFLIoZZluL3rWipgb8S80+pXhDenVx59NnSIkLzI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b3mw0mo48g1XYqGl1KLzGYWhF9OmlOsXrOiw/4Jmr9Sp2dGvl5NeqmR2aPmdvCwCw hMzGgTWLATc14Lqf0kZV91LuEJMGKIyW+++M3RQvXiWWKmAqfzm+B4O8QWjiQMv54h lqvSe4tlHsdbHfVYwq/81oFSt+2VTM8o8QFLbMP4= Date: Fri, 11 Oct 2019 14:08:47 +0200 From: Greg KH To: Dan Carpenter Cc: Wambui Karuga , devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals Message-ID: <20191011120847.GB1143018@kroah.com> References: <20191011105404.GA4774@kadam> <20191011120717.GA1143018@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191011120717.GA1143018@kroah.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 11, 2019 at 02:07:17PM +0200, Greg KH wrote: > On Fri, Oct 11, 2019 at 01:54:04PM +0300, Dan Carpenter wrote: > > On Thu, Oct 10, 2019 at 04:15:29PM +0300, Wambui Karuga wrote: > > > psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm)); > > > - if (psetauthparm == NULL) { > > > - kfree(pcmd); > > > + if (!psetauthparm) { > > > + kfree((unsigned char *)pcmd); > > > > This new cast is unnecessary and weird. > > Ah, I missed that, good catch. I'll go drop this patch now. And that caused the second patch to get dropped as well. I'll just drop them all, can you redo the whole series please? thanks, greg k-h