From: Davidlohr Bueso <dave@stgolabs.net>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Waiman Long <longman@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
1vier1@web.de, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: wake_q memory ordering
Date: Fri, 11 Oct 2019 08:46:23 -0700 [thread overview]
Message-ID: <20191011154623.zawmihahq6dria7u@linux-p48b> (raw)
In-Reply-To: <0312fc72-74f1-ea3e-8301-f94bba742735@colorfullife.com>
On Fri, 11 Oct 2019, Manfred Spraul wrote:
>I don't know. The new documentation would not have answered my
>question (is it ok to combine smp_mb__before_atomic() with
>atomic_relaxed()?). And it copies content already present in
>atomic_t.txt.
Well, the _relaxed (and release/acquire) extentions refer to a
_successful_ operation (LL/SC), and whether it has barriers on
each of the sides before and after. I thought you were mainly
worried about the failed CAS scenario, not the relaxed itself.
I don't know how this copies content from atomic_t.txt, at no
point does it talk about failed CAS.
>
>Thus: I would prefer if the first sentence of the paragraph is
>replaced: The list of operations should end with "...", and it should
>match what is in atomic_t.txt
I'll see about combining some of your changes in patch 5/5 of
your new series, but have to say I still prefer my documentation
change.
Thanks,
Davidlohr
prev parent reply other threads:[~2019-10-11 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 10:41 Manfred Spraul
2019-10-10 11:42 ` Peter Zijlstra
2019-10-10 12:13 ` Manfred Spraul
2019-10-10 12:32 ` Peter Zijlstra
2019-10-10 19:25 ` Davidlohr Bueso
2019-10-11 8:57 ` Manfred Spraul
2019-10-11 15:46 ` Davidlohr Bueso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011154623.zawmihahq6dria7u@linux-p48b \
--to=dave@stgolabs.net \
--cc=1vier1@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=manfred@colorfullife.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®