From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rui.zhang@intel.com, edubezval@gmail.com
Cc: daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org,
amit.kucheria@linaro.org
Subject: [PATCH 11/11] thermal: Move thermal governor structure to internal header
Date: Sat, 12 Oct 2019 08:52:55 +0200 [thread overview]
Message-ID: <20191012065255.23249-11-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20191012065255.23249-1-daniel.lezcano@linaro.org>
The thermal governor structure is a big structure where no
user should change value inside except via helper functions.
Move the structure to the internal header thus preventing external
code to be tempted by hacking the structure's variables.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/thermal_core.h | 20 ++++++++++++++++++++
include/linux/thermal.h | 21 +--------------------
2 files changed, 21 insertions(+), 20 deletions(-)
diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
index c75309d858ce..e54150fa4c5b 100644
--- a/drivers/thermal/thermal_core.h
+++ b/drivers/thermal/thermal_core.h
@@ -46,6 +46,26 @@ struct thermal_attr {
char name[THERMAL_NAME_LENGTH];
};
+/**
+ * struct thermal_governor - structure that holds thermal governor information
+ * @name: name of the governor
+ * @bind_to_tz: callback called when binding to a thermal zone. If it
+ * returns 0, the governor is bound to the thermal zone,
+ * otherwise it fails.
+ * @unbind_from_tz: callback called when a governor is unbound from a
+ * thermal zone.
+ * @throttle: callback called for every trip point even if temperature is
+ * below the trip point temperature
+ * @governor_list: node in thermal_governor_list (in thermal_core.c)
+ */
+struct thermal_governor {
+ char name[THERMAL_NAME_LENGTH];
+ int (*bind_to_tz)(struct thermal_zone_device *tz);
+ void (*unbind_from_tz)(struct thermal_zone_device *tz);
+ int (*throttle)(struct thermal_zone_device *tz, int trip);
+ struct list_head governor_list;
+};
+
static inline bool cdev_is_power_actor(struct thermal_cooling_device *cdev)
{
return cdev->ops->get_requested_power && cdev->ops->state2power &&
diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index 8daa179918a1..04264e8a2bce 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -45,6 +45,7 @@
struct thermal_zone_device;
struct thermal_cooling_device;
+struct thermal_governor;
struct thermal_instance;
struct thermal_attr;
@@ -206,26 +207,6 @@ struct thermal_zone_device {
enum thermal_notify_event notify_event;
};
-/**
- * struct thermal_governor - structure that holds thermal governor information
- * @name: name of the governor
- * @bind_to_tz: callback called when binding to a thermal zone. If it
- * returns 0, the governor is bound to the thermal zone,
- * otherwise it fails.
- * @unbind_from_tz: callback called when a governor is unbound from a
- * thermal zone.
- * @throttle: callback called for every trip point even if temperature is
- * below the trip point temperature
- * @governor_list: node in thermal_governor_list (in thermal_core.c)
- */
-struct thermal_governor {
- char name[THERMAL_NAME_LENGTH];
- int (*bind_to_tz)(struct thermal_zone_device *tz);
- void (*unbind_from_tz)(struct thermal_zone_device *tz);
- int (*throttle)(struct thermal_zone_device *tz, int trip);
- struct list_head governor_list;
-};
-
/* Structure that holds binding parameters for a zone */
struct thermal_bind_params {
struct thermal_cooling_device *cdev;
--
2.17.1
next prev parent reply other threads:[~2019-10-12 6:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 6:52 [PATCH 01/11] thermal: Move default governor config option to the " Daniel Lezcano
2019-10-12 6:52 ` [PATCH 02/11] thermal: Move struct thermal_attr to the private header Daniel Lezcano
2019-10-12 6:52 ` [PATCH 03/11] thermal: Move internal IPA functions Daniel Lezcano
2019-10-12 6:52 ` [PATCH 04/11] thermal: Move trip point structure definition to private header Daniel Lezcano
2019-10-12 6:52 ` [PATCH 05/11] thermal: Move set_trips function to the internal header Daniel Lezcano
2019-10-14 14:32 ` Amit Kucheria
2019-10-12 6:52 ` [PATCH 06/11] thermal: Move get_tz_trend " Daniel Lezcano
2019-10-12 6:52 ` [PATCH 07/11] thermal: Move get_thermal_instance " Daniel Lezcano
2019-10-12 6:52 ` [PATCH 08/11] thermal: Change IS_ENABLED to IFDEF in the header file Daniel Lezcano
2019-10-12 6:52 ` [PATCH 09/11] thermal: Remove stubs for thermal_zone_[un]bind_cooling_device Daniel Lezcano
2019-10-12 6:52 ` [PATCH 10/11] thermal: Remove thermal_zone_device_update() stub Daniel Lezcano
2019-10-12 6:52 ` Daniel Lezcano [this message]
2019-10-14 7:48 ` [PATCH 11/11] thermal: Move thermal governor structure to internal header kbuild test robot
2019-10-14 9:54 ` kbuild test robot
2019-10-14 14:32 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012065255.23249-11-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome