From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F5F2ECE58D for ; Mon, 14 Oct 2019 08:05:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2854F20650 for ; Mon, 14 Oct 2019 08:05:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571040351; bh=JMX1LApY2fbKeVzv4AKmUzSaxbEE2mGrMc7ILY5Utmc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ZaWHEqo788rw8bWeW3thfUNfaUiyvz4x4TtgPq5Ywj7Opjp6w6uYjQaWNK4bqoO0t Ri3+1yWpDQdzpmZE1s+MKpBNSOIjrnpy7iYhXF7bYmr96014yjcJHVPGzFB8LxgeA1 UR7cabMDUJ0KUeuwVxVLjNtoK5oqZ+fz4MEkJ/tU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730277AbfJNIFu (ORCPT ); Mon, 14 Oct 2019 04:05:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:51592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbfJNIFt (ORCPT ); Mon, 14 Oct 2019 04:05:49 -0400 Received: from localhost (unknown [122.167.124.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EC802054F; Mon, 14 Oct 2019 08:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571040348; bh=JMX1LApY2fbKeVzv4AKmUzSaxbEE2mGrMc7ILY5Utmc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0HX2BXwBBUVV6EdFcDo4PS3xZqvONejrn/66/Ku4UC2V64qZHV/jxFo+KCNiX6hlm Bo0H90rxwYt9Gfhi5DTuBZjNx5l3SP+sAE1qPoUNivDYdOBs5i3rf/jwZVV55t3fe2 pHNsxzdfIhJtHxQuNRZDdojM3EnLMsDbsASy6uv8= Date: Mon, 14 Oct 2019 13:35:44 +0530 From: Vinod Koul To: Robin Gong Cc: "dan.j.williams@intel.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "J.Lambrecht@TELEVIC.com" , "kernel@pengutronix.de" , dl-linux-imx , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1] dmaengine: imx-sdma: fix kernel hangs with SLUB slab allocator Message-ID: <20191014080544.GM2654@vkoul-mobl> References: <1569347584-3478-1-git-send-email-yibin.gong@nxp.com> <20191014080215.GL2654@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191014080215.GL2654@vkoul-mobl> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-10-19, 13:32, Vinod Koul wrote: > On 24-09-19, 09:49, Robin Gong wrote: > > Illegal memory will be touch if SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V3 > > (41) exceed the size of structure sdma_script_start_addrs(40), > > thus cause memory corrupt such as slob block header so that kernel > > trap into while() loop forever in slob_free(). Please refer to below > > code piece in imx-sdma.c: > > for (i = 0; i < sdma->script_number; i++) > > if (addr_arr[i] > 0) > > saddr_arr[i] = addr_arr[i]; /* memory corrupt here */ > > That issue was brought by commit a572460be9cf ("dmaengine: imx-sdma: Add > > support for version 3 firmware") because SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V3 > > (38->41 3 scripts added) not align with script number added in > > sdma_script_start_addrs(2 scripts). > > Applied, thanks And after applying I noticed the patch title is not apt. The patch title should reflect the change and not the cause or result. So I have modified the title to: "dmaengine: imx-sdma: fix size check for sdma script_number" Thanks -- ~Vinod