From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A40C10F14 for ; Tue, 15 Oct 2019 07:13:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3654F21835 for ; Tue, 15 Oct 2019 07:13:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="07Ro9DoD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727198AbfJOHNQ (ORCPT ); Tue, 15 Oct 2019 03:13:16 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:46491 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbfJOHNQ (ORCPT ); Tue, 15 Oct 2019 03:13:16 -0400 Received: by mail-ed1-f66.google.com with SMTP id r18so5286208eds.13 for ; Tue, 15 Oct 2019 00:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=42biyvPrM31S02FsXUC0MU+0R6tD+Grhb6Q0nsVz7Ds=; b=07Ro9DoDUOV+hGr1z0pDvrhKuUGay3/l/niOQeWdwuMjtweQYy+ib4C04lop8neHRr /Cofqv91xBd/zu/rW9CypWngXIM8TzIgl7XxcJ67lxemRhucFI/u0g+2HAA2gxwqVhV4 KqjjYjMw/bYk4EUR3ureh4UkvD30pN6OGzo7UscckZ+S3FknLUL4VY6kDkP308LPA9Qv +XgM84b5fGWauxm24KYhW7chdXFiPbnB+lPx7pvpaM8TF7/bwjeY+xAbZlerS3cMLFnc wXw7GCgaF9SCJDU0+TrJoSNVDxpbaodv03bNgmVOZQrJVvsgmSe2MS3nmbgHgPnPdvBQ hnEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=42biyvPrM31S02FsXUC0MU+0R6tD+Grhb6Q0nsVz7Ds=; b=Hm7Egk4XG8z8wd9RtqExmTwSOpcp/LR+v36hcQCNpo9tWjEfrEvTQgBe52Gblt6mjN uLwZwcOa1XraRYrjOSmQQefxnpVPIVML7CrzCm1BpDqtubVSpFuQ7ux1lguoaKIkOo4R MBQezai5ADAINH/44hfmQ5VA1fB6C3DGpkAF5SC/FtB1T8s8ZY99rk9vXa24VZkzpi81 qYArSiE3cN/mW5wgM32rx6tEzgOfHmBr/YjeMv2OcbB9mHdPPvTQTig4yG4OYH/0zsvB h/0llEs9+aqKf/wPRDF/eaIykED10Zlh6KnhCZYiXmiIkGXKxOea+qv+jrrEXO0bY6pZ KFhQ== X-Gm-Message-State: APjAAAWTdESKh9tPd9zSwwFQUL1RX6z7gtXkJXojADinW+feM6TSFFJc ZESFKs5Iuyy7JZbp2lr/ds+nOw== X-Google-Smtp-Source: APXvYqzkDKmEoyVN1f2OTnxxt1B+9UZ1DrV5ZExNh0mPSF0Uip8kLTW7XTtAyZQSYQT8uaXQrE7MCQ== X-Received: by 2002:a50:bac2:: with SMTP id x60mr31916901ede.96.1571123594739; Tue, 15 Oct 2019 00:13:14 -0700 (PDT) Received: from netronome.com (penelope-musen.rivierenbuurt.horms.nl. [2001:470:7eb3:404:c685:8ff:fe7c:9971]) by smtp.gmail.com with ESMTPSA id p4sm3575649eda.56.2019.10.15.00.13.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Oct 2019 00:13:13 -0700 (PDT) Date: Tue, 15 Oct 2019 09:13:12 +0200 From: Simon Horman To: Jeroen Hofstee Cc: kbuild test robot , Pankaj Sharma , "kbuild-all@lists.01.org" , "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "wg@grandegger.com" , "mkl@pengutronix.de" , "davem@davemloft.net" , "eugen.hristev@microchip.com" , "ludovic.desroches@microchip.com" , "pankaj.dubey@samsung.com" , "rcsekar@samsung.com" , Sriram Dash Subject: Re: [PATCH] can: m_can: fix boolreturn.cocci warnings Message-ID: <20191015071311.yssgqhoax46lfa7l@netronome.com> References: <1571052844-22633-1-git-send-email-pankj.sharma@samsung.com> <20191014150428.xhhc43ovkxm6oxf2@332d0cec05f4> <20191015055718.mypn63s2ovgwipk3@netronome.com> <9ad7810b-2205-3227-7ef9-0272f3714839@victronenergy.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ad7810b-2205-3227-7ef9-0272f3714839@victronenergy.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 15, 2019 at 06:37:54AM +0000, Jeroen Hofstee wrote: > Hi, > > On 10/15/19 7:57 AM, Simon Horman wrote: > > On Mon, Oct 14, 2019 at 11:04:28PM +0800, kbuild test robot wrote: > >> From: kbuild test robot > >> > >> drivers/net/can/m_can/m_can.c:783:9-10: WARNING: return of 0/1 in function 'is_protocol_err' with return type bool > >> > >> Return statements in functions returning bool should use > >> true/false instead of 1/0. > >> Generated by: scripts/coccinelle/misc/boolreturn.cocci > >> > >> Fixes: 46946163ac61 ("can: m_can: add support for handling arbitration error") > >> CC: Pankaj Sharma > >> Signed-off-by: kbuild test robot > >> --- > >> > >> url: https://github.com/0day-ci/linux/commits/Pankaj-Sharma/can-m_can-add-support-for-handling-arbitration-error/20191014-193532 > >> > >> m_can.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> --- a/drivers/net/can/m_can/m_can.c > >> +++ b/drivers/net/can/m_can/m_can.c > >> @@ -780,9 +780,9 @@ static inline bool is_lec_err(u32 psr) > >> static inline bool is_protocol_err(u32 irqstatus) > >> { > >> if (irqstatus & IR_ERR_LEC_31X) > >> - return 1; > >> + return true; > >> else > >> - return 0; > >> + return false; > >> } > >> > >> static int m_can_handle_protocol_error(struct net_device *dev, u32 irqstatus) > >> > > <2c> > > Perhaps the following is a nicer way to express this (completely untested): > > > > return !!(irqstatus & IR_ERR_LEC_31X); > > > > > Really...., !! for bool / _Bool types? why not simply: > > static inline bool is_protocol_err(u32 irqstatus) > return irqstatus & IR_ERR_LEC_31X; > } Good point, silly me.