From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 007C7ECE587 for ; Tue, 15 Oct 2019 07:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6F382089C for ; Tue, 15 Oct 2019 07:47:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="scY7fHtC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728176AbfJOHrU (ORCPT ); Tue, 15 Oct 2019 03:47:20 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:57588 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728011AbfJOHrU (ORCPT ); Tue, 15 Oct 2019 03:47:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=s0EYNpZgNDwByY0WfJi3InA5EJrO+lO4vHXQl/TaEIg=; b=scY7fHtCx4VoaknBVynCwMlXC wNUi1AYin5ebZ1VTcMe+XihF+rPUmPobROs8ZqrhG2LgjXlUQqMHCvTpQJZUr1oaz3xjpu2cICfKM aNSeqPBjLSddXaFXbzaaQQw6NWFQsQ4P65nZwEuwgg0fMepLkPKY7p46qKGJsQTsV5KWbKBtgFLv9 Pgc+ZJPXO5dbhIHlAZ6dv2Dh1/F2l9Ml2sCG95dA0ylvbR5Q9enkQR1+TcyY1FqpytthLdVdbXiLo Y99pAwSn4Ib1J/g079mZ3g+E+3kde2Nba67FVH1dbgt+nCTgyAaAKrSeqOnWyh9dYkDGLBoA53e/u 4b/b9iWOA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKHY5-0004l7-Il; Tue, 15 Oct 2019 07:47:17 +0000 Date: Tue, 15 Oct 2019 00:47:17 -0700 From: Christoph Hellwig To: Michal Simek Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Kate Stewart , Kuldeep Dave , Albert Ou , Greg Kroah-Hartman , Palmer Dabbelt , Masahiro Yamada , Firoz Khan , Paul Walmsley , Andrew Morton , Will Deacon , linux-riscv@lists.infradead.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH] microblaze: Include generic support for MSI irqdomains Message-ID: <20191015074717.GB8715@infradead.org> References: <20191008154604.GA7903@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 10, 2019 at 12:47:31PM +0200, Michal Simek wrote: > On 08. 10. 19 17:46, Christoph Hellwig wrote: > > On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote: > >> index e5c9170a07fc..83417105c00a 100644 > >> --- a/arch/microblaze/include/asm/Kbuild > >> +++ b/arch/microblaze/include/asm/Kbuild > >> @@ -25,6 +25,7 @@ generic-y += local64.h > >> generic-y += mcs_spinlock.h > >> generic-y += mm-arch-hooks.h > >> generic-y += mmiowb.h > >> +generic-y += msi.h > > > > Please just mark it as mandatory-y in the asm-generic makefile > > instead of requiring a sniplet for every architecture. > > > > But is it really mandatory for all architectures? What the mandatory-y keyword means is that every architecture that doesn't provide its own header gets the default one, which seems applicable here. Maybe the keyword is a bit misnamed and should be default-y or something like that.. But in this case I think we have a clear case of x86 vs the rest, which is unlikely to change in a major way.