From: Steven Rostedt <rostedt@goodmis.org>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: fix function type mismatches
Date: Tue, 15 Oct 2019 09:03:58 -0400 [thread overview]
Message-ID: <20191015090358.11ddda28@gandalf.local.home> (raw)
In-Reply-To: <20191015090055.789a0aed@gandalf.local.home>
On Tue, 15 Oct 2019 09:00:55 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -111,15 +111,22 @@
>
> #ifdef CONFIG_FTRACE_MCOUNT_RECORD
> #ifdef CC_USING_PATCHABLE_FUNCTION_ENTRY
> +/*
> + * Need to also make ftrace_graph_stub point to ftrace_stub
> + * so that the same stub location may have different protocols
> + * and not mess up with C verifiers.
> + */
> diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c
> index 7950a0356042..fa3ce10d0405 100644
> --- a/kernel/trace/fgraph.c
> +++ b/kernel/trace/fgraph.c
> @@ -332,9 +332,14 @@ int ftrace_graph_entry_stub(struct ftrace_graph_ent *trace)
> return 0;
> }
>
> +/*
> + * Simply points to ftrace_stub, but with the proper protocol.
> + * Defined by the linker script in linux/vmlinux.lds.h
> + */
> +extern void ftrace_graph_stub(struct ftrace_graph_ret *);
> +
s/protocol/prototype/g
Will update.
-- Steve
next prev parent reply other threads:[~2019-10-15 13:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 21:47 Sami Tolvanen
2019-10-10 21:12 ` Kees Cook
2019-10-11 18:26 ` Steven Rostedt
2019-10-14 20:00 ` Sami Tolvanen
2019-10-15 13:00 ` Steven Rostedt
2019-10-15 13:03 ` Steven Rostedt [this message]
2019-10-17 21:18 ` Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015090358.11ddda28@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®