From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97223C10F14 for ; Tue, 15 Oct 2019 19:28:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 690DF214AE for ; Tue, 15 Oct 2019 19:28:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="G90I0dyr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732283AbfJOT2s (ORCPT ); Tue, 15 Oct 2019 15:28:48 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:52609 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730038AbfJOT2r (ORCPT ); Tue, 15 Oct 2019 15:28:47 -0400 Received: by mail-wm1-f65.google.com with SMTP id r19so292153wmh.2 for ; Tue, 15 Oct 2019 12:28:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=EbAnyTOslp6v1Q8FsmUFH6BpJr8FNaYvIMIlQEjnqCI=; b=G90I0dyrX3/1JAVSlVemOrG13hF203/pZ3Lk38+XtGFF4rkUlZ/iPoV1/27W04fCiN rLpCP/3Dz4tB/k9Gq51AKs4+FJ1LW3x+x/bQdVmWSl036tb3ZB/sSuRMc0A3vXrj25ZN i7dh49TtP7P6EGenJ5aLCCZT9aHDh8pSWd5g04fxKv3T+uQL22Cn0LUD4jDYyOAnZllD 1kjxE3kIPbGN3ZQR9vPIA6GQAbuZE/2M2uwOgW7IFirWuitnCb86tY9t2WShf+n+d/by vvR7SIag0PpihD6oqYflk2DE7u4BsxgixPGQTxK/LkrkBW4o7ur01/8OJwnqNhUXb1Py QjCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=EbAnyTOslp6v1Q8FsmUFH6BpJr8FNaYvIMIlQEjnqCI=; b=EfFuLI51sK2M3+Q0n7TJcv3XDbfDKk4h6kYxTNBpNY99K/JE3NU7fmtLSACs60mUec jGQtCCN1sIe46KLFFkiaRFz711hfttWbHYl/Iggnse6KW8aT+aZINoOcjVVBrDh6rnzU ljXkgyIqfksO3ZHn34wQ1aWpCwYs9B9qiPHytRDKffhkorkxlkqCPS9Vti1JAtR8TxPC aXJT2wQbO6tpUU0q8F2GqdAYaz7Oefju2S2OLCx44bJ/IndmFcXQVqd2/GxH0EX2Oadh XPqFG1jpfZfacpw7jcGiDauMeX+ocs7IzpkL9gQ9egbTWMKVRGeZmJL7xQaeTf9UL/RQ Ypqg== X-Gm-Message-State: APjAAAUI4cyk8WSkWIHmKGzwjwYppPpbhZPz4dRPVCVkCNlzu01AQBwf psI87AvMCdY36Rp6tfSCl5L9jg== X-Google-Smtp-Source: APXvYqz7nP0l7vdHzimkwgpLFEg+eNxzWXUfJJzNLYDn7AUPiBz5wwZf6tij4i9ykaeLXoR8PZtrxQ== X-Received: by 2002:a05:600c:2318:: with SMTP id 24mr60488wmo.146.1571167724173; Tue, 15 Oct 2019 12:28:44 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id i1sm342582wmb.19.2019.10.15.12.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2019 12:28:43 -0700 (PDT) Date: Tue, 15 Oct 2019 12:28:36 -0700 From: Jakub Kicinski To: MarkLee Cc: "David S. Miller" , Sean Wang , John Crispin , Nelson Chang , Matthias Brugger , Andrew Lunn , Rob Herring , Mark Rutland , Rene van Dorst , , , , , Subject: Re: [PATCH net,v3 1/2] net: ethernet: mediatek: Fix MT7629 missing GMII mode support Message-ID: <20191015122836.78bff48f@cakuba.netronome.com> In-Reply-To: <20191014071518.11923-2-Mark-MC.Lee@mediatek.com> References: <20191014071518.11923-1-Mark-MC.Lee@mediatek.com> <20191014071518.11923-2-Mark-MC.Lee@mediatek.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Oct 2019 15:15:17 +0800, MarkLee wrote: > In the original design, mtk_phy_connect function will set ge_mode=1 > if phy-mode is GMII(PHY_INTERFACE_MODE_GMII) and then set the correct > ge_mode to ETHSYS_SYSCFG0 register. This logic was broken after apply > mediatek PHYLINK patch(Fixes tag), the new mtk_mac_config function will > not set ge_mode=1 for GMII mode hence the final ETHSYS_SYSCFG0 setting > will be incorrect for mt7629 GMII mode. This patch add the missing logic > back to fix it. > > Fixes: b8fc9f30821e ("net: ethernet: mediatek: Add basic PHYLINK support") > Signed-off-by: MarkLee LGTM, thanks