From: "Paul E. McKenney" <paulmck@kernel.org>
To: Lai Jiangshan <laijs@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org,
Lai Jiangshan <jiangshanlai@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Joel Fernandes <joel@joelfernandes.org>,
rcu@vger.kernel.org
Subject: Re: [PATCH 2/7] rcu: fix tracepoint string when RCU CPU kthread runs
Date: Tue, 15 Oct 2019 20:38:14 -0700 [thread overview]
Message-ID: <20191016033814.GX2689@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20191015102402.1978-3-laijs@linux.alibaba.com>
On Tue, Oct 15, 2019 at 10:23:57AM +0000, Lai Jiangshan wrote:
> "rcu_wait" is incorrct here, use "rcu_run" instead.
>
> Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
> Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
> ---
> kernel/rcu/tree.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 278798e58698..c351fc280945 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2485,7 +2485,7 @@ static void rcu_cpu_kthread(unsigned int cpu)
> int spincnt;
>
> for (spincnt = 0; spincnt < 10; spincnt++) {
> - trace_rcu_utilization(TPS("Start CPU kthread@rcu_wait"));
> + trace_rcu_utilization(TPS("Start CPU kthread@rcu_run"));
> local_bh_disable();
> *statusp = RCU_KTHREAD_RUNNING;
> local_irq_disable();
> @@ -2496,7 +2496,7 @@ static void rcu_cpu_kthread(unsigned int cpu)
> rcu_core();
> local_bh_enable();
> if (*workp == 0) {
> - trace_rcu_utilization(TPS("End CPU kthread@rcu_wait"));
> + trace_rcu_utilization(TPS("End CPU kthread@rcu_run"));
This one needs to stay as it was because this is where we wait when out
of work.
So I took the first hunk and dropped this second hunk.
Please let me know if I am missing something.
Thanx, Paul
> *statusp = RCU_KTHREAD_WAITING;
> return;
> }
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-10-16 3:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 10:23 [PATCH 0/7] rcu: cleanups Lai Jiangshan
2019-10-15 10:23 ` [PATCH 1/7] rcu: fix incorrect conditional compilation Lai Jiangshan
2019-10-16 3:35 ` Paul E. McKenney
2019-10-15 10:23 ` [PATCH 2/7] rcu: fix tracepoint string when RCU CPU kthread runs Lai Jiangshan
2019-10-16 3:38 ` Paul E. McKenney [this message]
2019-10-16 4:24 ` Lai Jiangshan
2019-10-16 14:14 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016033814.GX2689@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=laijs@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®