From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35BC3FA372B for ; Wed, 16 Oct 2019 09:54:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BD96218DE for ; Wed, 16 Oct 2019 09:54:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BjNRpsJl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404348AbfJPJx7 (ORCPT ); Wed, 16 Oct 2019 05:53:59 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:36338 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404266AbfJPJx6 (ORCPT ); Wed, 16 Oct 2019 05:53:58 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8361443E; Wed, 16 Oct 2019 11:53:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1571219635; bh=gjcnDXgTaHH8i0rQWIk9tmPvMqWjkUNsCfrg0iTzX/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BjNRpsJlVWhEN2gh2yeS7XLz3wM+GhoW+gTtqVPxOvthF6gcJDbUAfd6owFXi7IBC M+7+h31pY9s8i/nlfZWjSj92dvu1HLAOw+5QWPHnmHlrS1q1wmxsFBuIw33JDUOugs o9CqGq9H5Oy1FnBCXb+66ZIBJfklmfTCCa8cK9ws= Date: Wed, 16 Oct 2019 12:53:52 +0300 From: Laurent Pinchart To: Hariprasad Kelam Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: make use of devm_platform_ioremap_resource Message-ID: <20191016095352.GA5175@pendragon.ideasonboard.com> References: <1570517752-30991-1-git-send-email-hariprasad.kelam@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1570517752-30991-1-git-send-email-hariprasad.kelam@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Hariprasad, Thank you for the patch. As the patch only touches the omap4iss driver, you could have made the subject line a bit more specific, for instance "staging: media: omap4iss: Use devm_platform_ioremap_resource". No big deal though. On Tue, Oct 08, 2019 at 12:25:51PM +0530, hariprasadKelamhariprasad.kelam@gmail.com wrote: > From: Hariprasad Kelam > > fix below issue reported by coccicheck > drivers/staging//media/omap4iss/iss.c:915:1-15: WARNING: Use > devm_platform_ioremap_resource for iss -> regs [ res ] > > Signed-off-by: Hariprasad Kelam The change looks good to me. Reviewed-by: Laurent Pinchart and applied to my tree for v5.5. > --- > drivers/staging/media/omap4iss/iss.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c > index 1a966cb..6fb60b5 100644 > --- a/drivers/staging/media/omap4iss/iss.c > +++ b/drivers/staging/media/omap4iss/iss.c > @@ -908,11 +908,7 @@ static int iss_map_mem_resource(struct platform_device *pdev, > struct iss_device *iss, > enum iss_mem_resources res) > { > - struct resource *mem; > - > - mem = platform_get_resource(pdev, IORESOURCE_MEM, res); > - > - iss->regs[res] = devm_ioremap_resource(iss->dev, mem); > + iss->regs[res] = devm_platform_ioremap_resource(pdev, res); > > return PTR_ERR_OR_ZERO(iss->regs[res]); > } -- Regards, Laurent Pinchart