From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 118E9FA372A for ; Wed, 16 Oct 2019 14:51:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2B59218DE for ; Wed, 16 Oct 2019 14:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571237467; bh=Xh/9gWmwBKdF+8neE3kItdxVMfpHXwc3n8w1uZywGNQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ROH4tnF69OW2u4pxKt59eUoeg5Fe3AZ5GL5ZSuojvdZUEjhxhESMQpkrNL0j16SPT 9OwTSJy5vt4nAxdxTZz2ys5ji6YNksHcPYmPAQgZPdKjVq/cgquoZ1NxHKHVD62v2K VAsiJ6kG/P7Z9GsBxv1PdgiwHj5k6O+TnSO6LxLg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393836AbfJPOvG (ORCPT ); Wed, 16 Oct 2019 10:51:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:34234 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390729AbfJPOvG (ORCPT ); Wed, 16 Oct 2019 10:51:06 -0400 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 331AE2168B; Wed, 16 Oct 2019 14:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571237465; bh=Xh/9gWmwBKdF+8neE3kItdxVMfpHXwc3n8w1uZywGNQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bMkLi5d63UN14+72d9h18uH19CkeKG76vGq+CqQ+wIG2Cyem630Ojwrt9CEOdzh1f nfcG0oLaZc2le2vb93goK32+ObpHGn+url2irqclWJw+pWdZempUJgMh0VLuA1KDwD FgYwaZLYrXiSq3mJDbHG9vjPT2zA1qR1eMkuVBy4= Date: Wed, 16 Oct 2019 16:51:03 +0200 From: Maxime Ripard To: Code Kipper Cc: Chen-Yu Tsai , linux-sunxi , linux-arm-kernel , Liam Girdwood , Mark Brown , linux-kernel , Linux-ALSA , "Andrea Venturi (pers)" Subject: Re: [PATCH v6 1/7] ASoC: sun4i-i2s: Move channel select offset Message-ID: <20191016145103.im4h75qi2fcdcmar@gilmour> References: <20191016070740.121435-1-codekipper@gmail.com> <20191016070740.121435-2-codekipper@gmail.com> <20191016080420.4cbxn2hdt3wwtrhl@gilmour> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fi6amry3fbotqfax" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fi6amry3fbotqfax Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 16, 2019 at 10:41:31AM +0200, Code Kipper wrote: > On Wed, 16 Oct 2019 at 10:04, Maxime Ripard wrote: > > > > On Wed, Oct 16, 2019 at 09:07:34AM +0200, codekipper@gmail.com wrote: > > > From: Marcus Cooper > > > > > > On the newer SoCs the offset is used to set the mode of the > > > connection. As it is to be used elsewhere then it makes sense > > > to move it to the main structure. > > > > Elsewhere where, and to do what? > Thanks...How does this sound? > > As it is to be used to set the same offset for each TX data channel in use > during multi-channel audio then let's move it to the main structure. That still doesn't explain why you want to move it to the main structure. It's there, it's calculated already, and can be used during multi-channel audio if you set it up in the same function. What you need to explain is why you can't do it in the same function. Maxime --fi6amry3fbotqfax Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXacuVwAKCRDj7w1vZxhR xTaQAP0X2iGfJ5IY9S8B+s9Zh5MP11erZjYLItvMfIJTyW5EAgD/QxPJRbfuSz03 Mqd/XK6k/sf6xBYpSzArepQAruvCDQs= =rCXO -----END PGP SIGNATURE----- --fi6amry3fbotqfax--