From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53181ECE58E for ; Thu, 17 Oct 2019 09:52:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E72F21835 for ; Thu, 17 Oct 2019 09:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571305951; bh=heLEKgwZ+8tjeXiZgv0CPgKfpmZiF5bmE7FHzvgHG+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HDDazf0q7cAfcVR9mX6TJf3EEp3fuc8DgtMbFKWKb01y/D7aEyv/Li71VuV0vnnBI XHnHsE5PHAsIN5Qy/YaqzCp3fvb47SL/t4Hds4tzAQlK3mbOH7898Y5X+qQDOuqGFf U9HxTxs9SoJ4dyCdktgITNlYiFaQTmV+S7eODWE0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439621AbfJQJwa (ORCPT ); Thu, 17 Oct 2019 05:52:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:36716 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393728AbfJQJw3 (ORCPT ); Thu, 17 Oct 2019 05:52:29 -0400 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B95B62089C; Thu, 17 Oct 2019 09:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571305948; bh=heLEKgwZ+8tjeXiZgv0CPgKfpmZiF5bmE7FHzvgHG+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V+YmYI1z9eZrzwEKTLFUr4EVSMVwK9S3XiuOS6OyFaaq+ox6zAiNOaHGNcYHm9sEo SylGURPaZBepmZVpjBV+KovC6jML6u+iyobMfY9FjT+yOtJc8+7QGJhbK5lE2hk0yb +MHx+XDdULSnmYjPTqOAXJLSD3MyflKJ/JGrKKNw= Date: Thu, 17 Oct 2019 11:52:25 +0200 From: Maxime Ripard To: Jagan Teki Cc: Chen-Yu Tsai , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Michael Trimarchi , Icenowy Zheng , linux-sunxi , dri-devel , linux-arm-kernel , linux-kernel , devicetree Subject: Re: [PATCH v10 5/6] arm64: dts: allwinner: a64: Add MIPI DSI pipeline Message-ID: <20191017095225.ntx647ivegaldlyf@gilmour> References: <20191005141913.22020-1-jagan@amarulasolutions.com> <20191005141913.22020-6-jagan@amarulasolutions.com> <20191007105708.raxavxk4n7bvxh7x@gilmour> <20191016080306.44pmo3rfmtnkgosq@gilmour> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qmuvblcb44ik4jdi" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qmuvblcb44ik4jdi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 16, 2019 at 02:19:44PM +0530, Jagan Teki wrote: > On Wed, Oct 16, 2019 at 1:33 PM Maxime Ripard wrote: > > > > On Mon, Oct 14, 2019 at 05:37:50PM +0530, Jagan Teki wrote: > > > On Mon, Oct 7, 2019 at 4:27 PM Maxime Ripard wrote: > > > > > > > > On Sat, Oct 05, 2019 at 07:49:12PM +0530, Jagan Teki wrote: > > > > > Add MIPI DSI pipeline for Allwinner A64. > > > > > > > > > > - dsi node, with A64 compatible since it doesn't support > > > > > DSI_SCLK gating unlike A33 > > > > > - dphy node, with A64 compatible with A33 fallback since > > > > > DPHY on A64 and A33 is similar > > > > > - finally, attach the dsi_in to tcon0 for complete MIPI DSI > > > > > > > > > > Signed-off-by: Jagan Teki > > > > > Tested-by: Merlijn Wajer > > > > > --- > > > > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 38 +++++++++++++++++++ > > > > > 1 file changed, 38 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > > > index 69128a6dfc46..ad4170b8aee0 100644 > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > > > @@ -382,6 +382,12 @@ > > > > > #address-cells = <1>; > > > > > #size-cells = <0>; > > > > > reg = <1>; > > > > > + > > > > > + tcon0_out_dsi: endpoint@1 { > > > > > + reg = <1>; > > > > > + remote-endpoint = <&dsi_in_tcon0>; > > > > > + allwinner,tcon-channel = <1>; > > > > > + }; > > > > > }; > > > > > }; > > > > > }; > > > > > @@ -1003,6 +1009,38 @@ > > > > > status = "disabled"; > > > > > }; > > > > > > > > > > + dsi: dsi@1ca0000 { > > > > > + compatible = "allwinner,sun50i-a64-mipi-dsi"; > > > > > + reg = <0x01ca0000 0x1000>; > > > > > + interrupts = ; > > > > > + clocks = <&ccu CLK_BUS_MIPI_DSI>; > > > > > + clock-names = "bus"; > > > > > > > > This won't validate with the bindings you have either here, since it > > > > still expects bus and mod. > > > > > > > > I guess in that cas, we can just drop clock-names, which will require > > > > a bit of work on the driver side as well. > > > > > > Okay. > > > mod clock is not required for a64, ie reason we have has_mod_clk quirk > > > patch. Adjust the clock-names: on dt-bindings would make sense here, > > > what do you think? > > > > I'm confused, what are you suggesting? > > Sorry for the confusion. > > The mod clock is not required for A64 and we have a patch for handling > mod clock using has_mod_clk quirk(on the series), indeed the mod clock > is available in A31 and not needed for A64. So, to satisfy this > requirement the clock-names on dt-bindings can update to make mod > clock-name is optional and bus clock is required. No, the bus clock name is not needed if there's only one clock. > I'm not exactly sure, this is correct but trying to understand if it > is possible or not? something like > > clocks: > minItems: 1 > maxItems: 2 > items: > - description: Bus Clock > - description: Module Clock That's correct. > clock-names: > minItems: 1 > maxItems: 2 > items: > - const: bus > - const: mod Here, just keep the current clock-names definition, and make it required only for SoCs that are not the A64 Maxime --qmuvblcb44ik4jdi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXag52QAKCRDj7w1vZxhR xb61APwI3pT187DnoWidQOdHcwSDhwtfnY5i43XaAc7tdaAkdQEAp+g/w4/dneO3 Vt2IfHqycYDGHUPJU8g6q4R6umrzPA0= =ObSz -----END PGP SIGNATURE----- --qmuvblcb44ik4jdi--