From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66419FA3736 for ; Thu, 17 Oct 2019 10:19:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B7812082C for ; Thu, 17 Oct 2019 10:19:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2501936AbfJQKTU (ORCPT ); Thu, 17 Oct 2019 06:19:20 -0400 Received: from [217.140.110.172] ([217.140.110.172]:38226 "EHLO foss.arm.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S2408801AbfJQKTP (ORCPT ); Thu, 17 Oct 2019 06:19:15 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A7D311BC0; Thu, 17 Oct 2019 03:18:46 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6F40F3F718; Thu, 17 Oct 2019 03:18:45 -0700 (PDT) Date: Thu, 17 Oct 2019 11:18:43 +0100 From: Lorenzo Pieralisi To: "Ben Dooks (Codethink)" Cc: linux-kernel@lists.codethink.co.uk, Thomas Petazzoni , Jason Cooper , Andrew Murray , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: mvebu: mvebu_pcie_map_registers __iomem fix Message-ID: <20191017101843.GC9589@e121166-lin.cambridge.arm.com> References: <20191015161148.4413-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191015161148.4413-1-ben.dooks@codethink.co.uk> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 15, 2019 at 05:11:48PM +0100, Ben Dooks (Codethink) wrote: > Fix the return type of mvebu_pcie_map_registers in the > error path to have __iomem on it. Fixes the following > sparse warning: > > drivers/pci/controller/pci-mvebu.c:716:31: warning: incorrect type in return expression (different address spaces) > drivers/pci/controller/pci-mvebu.c:716:31: expected void [noderef] * > drivers/pci/controller/pci-mvebu.c:716:31: got void * > > Signed-off-by: Ben Dooks > --- > Cc: Thomas Petazzoni > Cc: Jason Cooper > Cc: Lorenzo Pieralisi > Cc: Andrew Murray > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/pci/controller/pci-mvebu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to pci/misc, thanks. Lorenzo > diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c > index ed032e9a3156..153a64676bc9 100644 > --- a/drivers/pci/controller/pci-mvebu.c > +++ b/drivers/pci/controller/pci-mvebu.c > @@ -713,7 +713,7 @@ static void __iomem *mvebu_pcie_map_registers(struct platform_device *pdev, > > ret = of_address_to_resource(np, 0, ®s); > if (ret) > - return ERR_PTR(ret); > + return (void __iomem *)ERR_PTR(ret); > > return devm_ioremap_resource(&pdev->dev, ®s); > } > -- > 2.23.0 >