From: Jonathan Corbet <corbet@lwn.net>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: linux-doc@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Cornelia Huck <cohuck@redhat.com>,
Logan Gunthorpe <logang@deltatee.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: driver-api: pti_intel_mid: Enable syntax highlighting for C code block
Date: Fri, 18 Oct 2019 09:45:05 -0600 [thread overview]
Message-ID: <20191018094505.58a5efd4@lwn.net> (raw)
In-Reply-To: <20191004170124.13543-1-j.neuschaefer@gmx.net>
On Fri, 4 Oct 2019 19:01:19 +0200
Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
> This makes the code snippet more readable.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> Documentation/driver-api/pti_intel_mid.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/driver-api/pti_intel_mid.rst b/Documentation/driver-api/pti_intel_mid.rst
> index 20f1cff42d5f..bacc2a4ee89f 100644
> --- a/Documentation/driver-api/pti_intel_mid.rst
> +++ b/Documentation/driver-api/pti_intel_mid.rst
> @@ -49,7 +49,9 @@ but is not just blindly executing as 'root'. Keep in mind
> the use of ioctl(,TIOCSETD,) is not specific to the n_tracerouter
> and n_tracesink line discpline drivers but is a generic
> operation for a program to use a line discpline driver
> -on a tty port other than the default n_tty::
> +on a tty port other than the default n_tty:
> +
> +.. code-block:: c
>
> /////////// To hook up n_tracerouter and n_tracesink /////////
>
> --
> 2.20.1
I had to ponder on this a bit...the addition of that sort of markup tends
to clutter the plain-text reading experience, and I'm personally not
hugely attached to syntax highlighting. But others feel differently, I
guess, so I applied it. I'm not sure I want to see a flood of this kind
of change coming in, though.
Thanks,
jon
prev parent reply other threads:[~2019-10-18 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 17:01 Jonathan Neuschäfer
2019-10-18 15:45 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018094505.58a5efd4@lwn.net \
--to=corbet@lwn.net \
--cc=cohuck@redhat.com \
--cc=j.neuschaefer@gmx.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mchehab+samsung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®