From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4952BCA9EA9 for ; Fri, 18 Oct 2019 18:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24B9721835 for ; Fri, 18 Oct 2019 18:40:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="cjFTfPVv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505925AbfJRSke (ORCPT ); Fri, 18 Oct 2019 14:40:34 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:46042 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502264AbfJRSkc (ORCPT ); Fri, 18 Oct 2019 14:40:32 -0400 Received: by mail-lj1-f194.google.com with SMTP id q64so7175402ljb.12 for ; Fri, 18 Oct 2019 11:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=DO/a/phXhl0ktnXCOi2dJ5+kOviduNbcapLpkYYyEWk=; b=cjFTfPVvbl8MsUWT2blqjI7D/UzWWqMscY/aoCSNagnAdLyZQUeALz92b4699wBlT+ IdWkW+u7rupW5TONGtLImo8d+MudfU57UxSXGjgQclwP2J1fL00HtCvYrSnItcRQGqqA wqAVx4fbKWYXA6welrsOhQbGhWXCy3BH8mA97gbL/9FgT8AxoAL0PzpvUlxvnq5PbQY2 LEUyZn1y8d0hk2zpgTe/pXYFmaS5Jld+iImenu3pIk7Cue4giiHplBtsQdUznpFBfj72 4XFpY/UEBA7D54cOpRL8puvNcQ4v8gC62q5GcVphNUe3k1nSIxV8+LVNiYjRAIvABOOg mn3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=DO/a/phXhl0ktnXCOi2dJ5+kOviduNbcapLpkYYyEWk=; b=YA39QSuZwNNakKxAmiQCmbdTeyoF+Fc/7Pk2u2XW6EYeYd7tpKPxPSSwfIlxD02C1q t+yvnjwYC/Tfta9dH0l8r+i77qC2+aDzoKFwFT9lNLBfdt4P8I4XhKj1OmifWLxmmAFn mEpP3HXGhR1DOVbi2RAdESUQIku3Uxb9gBQWlv/L8y+g1ZCN/rVwha468i1EljMybkud +bm9R4sq4hKmeAr5a+Telrxs/kJ8Ox2MLl/NWR/rgLWL5ufJfENSr69CuEgaJJw0CxeD patvJ03i5lK9HbZjz8L6IJv2VHdsoQEzoA5JGJFYV2s0iyyzaCPNa2RTC0Krgxo483f0 zPvw== X-Gm-Message-State: APjAAAUlu8MoZwewcTuz6hs/eqF5GyV/5HwqgrWekfwIKQ0QTmk4atvQ atUO+4HPdhtkWdifC2Isfn07kw== X-Google-Smtp-Source: APXvYqxVwKHqQth0WuJkrBlEYr1piTk8a9b4URutbVdDlPpWcrSkFRNIVYQf5fyo7E/Y60YvCoBoCw== X-Received: by 2002:a2e:a41a:: with SMTP id p26mr7331304ljn.49.1571424031135; Fri, 18 Oct 2019 11:40:31 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id c4sm2716034lfm.4.2019.10.18.11.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 11:40:30 -0700 (PDT) Date: Fri, 18 Oct 2019 11:40:24 -0700 From: Jakub Kicinski To: Huazhong Tan Cc: , , , , , , Yonglong Liu Subject: Re: [PATCH net] net: hns3: fix mis-counting IRQ vector numbers issue Message-ID: <20191018114024.2102cde5@cakuba.netronome.com> In-Reply-To: <1571370179-52008-1-git-send-email-tanhuazhong@huawei.com> References: <1571370179-52008-1-git-send-email-tanhuazhong@huawei.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Oct 2019 11:42:59 +0800, Huazhong Tan wrote: > From: Yonglong Liu > > Currently, the num_msi_left means the vector numbers of NIC, > but if the PF supported RoCE, it contains the vector numbers > of NIC and RoCE(Not expected). > > This may cause interrupts lost in some case, because of the > NIC module used the vector resources which belongs to RoCE. > > This patch adds a new variable num_nic_msi to store the vector > numbers of NIC, and adjust the default TQP numbers and rss_size > according to the value of num_nic_msi. > > Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") > Signed-off-by: Yonglong Liu > Signed-off-by: Huazhong Tan LGTM, thanks!