From: Ayman Bagabas <ayman.bagabas@gmail.com>
To: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ayman Bagabas <ayman.bagabas@gmail.com>,
Mattias Jacobsson <2pi@mok.nu>, Takashi Iwai <tiwai@suse.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
kbuild test robot <lkp@intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] platform/x86: huawei-wmi: No need to check for battery name
Date: Sun, 20 Oct 2019 13:00:08 -0400 [thread overview]
Message-ID: <20191020170020.26251-2-ayman.bagabas@gmail.com> (raw)
In-Reply-To: <20191020170020.26251-1-ayman.bagabas@gmail.com>
No need to check for battery name, we already check if the WMI function is
available in huawei_wmi_battery_setup.
Fixes: 355a070b09ab ("platform/x86: huawei-wmi: Add battery charging thresholds")
Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
---
drivers/platform/x86/huawei-wmi.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
index 26041d44286a..7373a65a61d3 100644
--- a/drivers/platform/x86/huawei-wmi.c
+++ b/drivers/platform/x86/huawei-wmi.c
@@ -471,10 +471,6 @@ static DEVICE_ATTR_RW(charge_control_thresholds);
static int huawei_wmi_battery_add(struct power_supply *battery)
{
- /* Huawei laptops come with one battery only */
- if (strcmp(battery->desc->name, "BAT") != 1)
- return -ENODEV;
-
device_create_file(&battery->dev, &dev_attr_charge_control_start_threshold);
device_create_file(&battery->dev, &dev_attr_charge_control_end_threshold);
--
2.21.0
next prev parent reply other threads:[~2019-10-20 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 17:00 [PATCH 1/3] platform/x86: huawei-wmi: Stricter battery thresholds set Ayman Bagabas
2019-10-20 17:00 ` Ayman Bagabas [this message]
2019-10-20 17:00 ` [PATCH 3/3] platform/x86: huawei-wmi: Remove unnecessary battery mutex Ayman Bagabas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191020170020.26251-2-ayman.bagabas@gmail.com \
--to=ayman.bagabas@gmail.com \
--cc=2pi@mok.nu \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®