From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABA42CA9EB5 for ; Mon, 21 Oct 2019 09:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AADF206C2 for ; Mon, 21 Oct 2019 09:38:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbfJUJio (ORCPT ); Mon, 21 Oct 2019 05:38:44 -0400 Received: from mga05.intel.com ([192.55.52.43]:10541 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727309AbfJUJio (ORCPT ); Mon, 21 Oct 2019 05:38:44 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2019 02:38:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,323,1566889200"; d="scan'208";a="200379705" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003.jf.intel.com with ESMTP; 21 Oct 2019 02:38:40 -0700 Received: from andy by smile with local (Exim 4.92.2) (envelope-from ) id 1iMU99-0002Ct-TE; Mon, 21 Oct 2019 12:38:39 +0300 Date: Mon, 21 Oct 2019 12:38:39 +0300 From: Andy Shevchenko To: Anatol Belski Cc: "linux-kernel@vger.kernel.org" , Mika Westerberg , Michael Jamet , "David S . Miller" , "trivial@kernel.org" , Masahiro Yamada , Nick Desaulniers Subject: Re: [PATCH v2] include/linux/byteorder/generic.h: fix signed/unsigned warnings Message-ID: <20191021093839.GM32742@smile.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 21, 2019 at 09:27:37AM +0000, Anatol Belski wrote: > From: Anatol Belski > > This fixes the warnings like below, thrown by GCC > > warning: comparison of integer expressions of different signedness: \ > ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare] > 195 | for (i = 0; i < len; i++) > | ^ We have explicitly disabled this warnings in the kernel Makefile. How did you achieve this? (yes, I know the possible answer, perhaps this has to be mentioned as well) Now I see some inconsistency with this warning between GCC and Clang. Add related people to the discussion. > Signed-off-by: Anatol Belski > --- Changelog is missing. (No need to resend just for this, it's for your future contributions) -- With Best Regards, Andy Shevchenko