From: Peter Zijlstra <peterz@infradead.org>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Stephane Eranian <eranian@google.com>,
Ian Rogers <irogers@google.com>, Song Liu <songliubraving@fb.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] perf/core,x86: introduce sync_task_ctx() method at struct pmu
Date: Mon, 21 Oct 2019 12:27:06 +0200 [thread overview]
Message-ID: <20191021102706.GE1800@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <c75134ef-b71b-c080-8ee1-c09fb9fae764@linux.intel.com>
On Fri, Oct 18, 2019 at 12:42:44PM +0300, Alexey Budankov wrote:
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 61448c19a132..60bf17af69f0 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -409,6 +409,13 @@ struct pmu {
> */
> size_t task_ctx_size;
>
> + /*
> + * PMU specific parts of task perf event context (i.e. ctx->task_ctx_data)
> + * can be synchronized using this function. See Intel LBR callstack support
> + * implementation and Perf core context switch handling callbacks for usage
> + * examples.
You're forgetting to mark this: Optional
> + */
> + void (*sync_task_ctx) (void *one, void *another);
The traditional argment names for context switching functions are prev
and next.
next prev parent reply other threads:[~2019-10-21 10:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 9:17 [PATCH v3 0/4]: perf/core: fix restoring of Intel LBR call stack on a context switch Alexey Budankov
2019-10-18 9:42 ` [PATCH v3 1/4] perf/core,x86: introduce sync_task_ctx() method at struct pmu Alexey Budankov
2019-10-21 10:27 ` Peter Zijlstra [this message]
2019-10-21 11:24 ` Alexey Budankov
2019-10-18 9:43 ` [PATCH v3 2/4] perf/x86: install platform specific sync_task_ctx adapter Alexey Budankov
2019-10-18 9:44 ` [PATCH v3 3/4] perf/x86/intel: implement LBR callstacks context synchronization Alexey Budankov
2019-10-18 9:45 ` [PATCH v3 4/4] perf/core,x86: synchronize PMU task contexts on optimized context switches Alexey Budankov
2019-10-21 7:59 ` Ingo Molnar
2019-10-21 10:00 ` Alexey Budankov
2019-10-21 10:37 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2019-10-16 14:20 [PATCH v3 0/4]: perf/core: fix restoring of Intel LBR call stack on a context switch Alexey Budankov
2019-10-16 14:25 ` [PATCH v3 1/4] perf/core,x86: introduce sync_task_ctx() method at struct pmu Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021102706.GE1800@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®