From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAA2DCA9EAF for ; Mon, 21 Oct 2019 20:51:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C210C2084B for ; Mon, 21 Oct 2019 20:51:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lbv5YQgU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730473AbfJUUvu (ORCPT ); Mon, 21 Oct 2019 16:51:50 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:33624 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730447AbfJUUvs (ORCPT ); Mon, 21 Oct 2019 16:51:48 -0400 Received: by mail-qt1-f194.google.com with SMTP id r5so23383712qtd.0; Mon, 21 Oct 2019 13:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gP5aOGQm4RR5GKmbETJdksv4+Dy+n4KwJgPC+qtGMS4=; b=Lbv5YQgUMc4hjqTtCjXgAOUYrLfjzad1Mv/7k3vVcHQMXYKsOSEZQW9mpUtZnBv89h W4BoyD2RnNqkfprfA9aoPVC+CHJ8/gvaK6c/rT85Xqv+udNExtaN7jasi8uKdZkwhIpN kS+ZmdIA4Br215x3Geea3DJ8HQQsmBknv7mCzFAFjShXFMaSo7K+hWWTI0+W6UvQzyz3 vEpE/ehZMSkYnID4X1z7MPPg5LWkAn0vEVkx9FimEdfuwDFiokq1OdyTQM3xCXH3rnAT oq7rNqetqcJObM9HgVpNLzQdoHONSYTN3pyvywZ876PS8gvkmmbAjM21ke6YGbubaRtS Yymw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gP5aOGQm4RR5GKmbETJdksv4+Dy+n4KwJgPC+qtGMS4=; b=MucsVzX8zO/N71x9JyGnCmBQdZV4O7Ch+S9JCswxFE/Un8Rcnhds0XA6fD9S/cx0A6 CZAjzqMj+Njyr+uFwcjx6A5rVsKSGDtVQMBirISLKdTxX33aXW3Dc25vtL1E5R0wtztQ fTkD1T0halHQaVEtyVUjvxW9mDBrrri0s9vFA0IIcIlujdC8aZ3ftuqBFO5veLTaW5LF 7AcsuoopJAAEisCX+1OYlLIXPHz+mKmTLf3Xv82zECjpZnlu1CdLZtbQk7Y+3CyzZH9W eO+A4JH9isbBbxv+GeCP+5S1rxECZndP5sFgagdE8y10HDFQGVb19ZXOuoixkYH6phTU zfCQ== X-Gm-Message-State: APjAAAXxnxx/CjeuEJ+/QFOSHbvbyUUhCS2PJVOWJJ+4z0Yfx7IgWtco prMjwYv9ICd7dPX1vb+kx4c= X-Google-Smtp-Source: APXvYqwqgl2+x5QDiF30Xi6fe1sHX39dluDbPbiQdvGRO5PLttsHdkhV3cdbNqv85ppspZKJmDd65A== X-Received: by 2002:a05:6214:4a:: with SMTP id c10mr8293515qvr.89.1571691107093; Mon, 21 Oct 2019 13:51:47 -0700 (PDT) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id y5sm8292049qki.108.2019.10.21.13.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 13:51:46 -0700 (PDT) From: Vivien Didelot To: "David S. Miller" Cc: linux-kernel@vger.kernel.org, Vivien Didelot , Florian Fainelli , Andrew Lunn , netdev@vger.kernel.org Subject: [PATCH net-next v2 07/16] net: dsa: use ports list to find a port by node Date: Mon, 21 Oct 2019 16:51:21 -0400 Message-Id: <20191021205130.304149-8-vivien.didelot@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191021205130.304149-1-vivien.didelot@gmail.com> References: <20191021205130.304149-1-vivien.didelot@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the new ports list instead of iterating over switches and their ports to find a port from a given node. Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli --- net/dsa/dsa2.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index 623805ba8e1a..a4de7ff8b19b 100644 --- a/net/dsa/dsa2.c +++ b/net/dsa/dsa2.c @@ -113,22 +113,11 @@ static bool dsa_port_is_user(struct dsa_port *dp) static struct dsa_port *dsa_tree_find_port_by_node(struct dsa_switch_tree *dst, struct device_node *dn) { - struct dsa_switch *ds; struct dsa_port *dp; - int device, port; - - for (device = 0; device < DSA_MAX_SWITCHES; device++) { - ds = dst->ds[device]; - if (!ds) - continue; - for (port = 0; port < ds->num_ports; port++) { - dp = &ds->ports[port]; - - if (dp->dn == dn) - return dp; - } - } + list_for_each_entry(dp, &dst->ports, list) + if (dp->dn == dn) + return dp; return NULL; } -- 2.23.0