From: Vivien Didelot <vivien.didelot@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org
Subject: [PATCH net-next v2 08/16] net: dsa: use ports list to setup multiple master devices
Date: Mon, 21 Oct 2019 16:51:22 -0400 [thread overview]
Message-ID: <20191021205130.304149-9-vivien.didelot@gmail.com> (raw)
In-Reply-To: <20191021205130.304149-1-vivien.didelot@gmail.com>
Now that we have a potential list of CPU ports, make use of it instead
of only configuring the master device of an unique CPU port.
Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
---
net/dsa/dsa2.c | 22 +++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index a4de7ff8b19b..514c0195e2e8 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -493,19 +493,27 @@ static void dsa_tree_teardown_switches(struct dsa_switch_tree *dst)
static int dsa_tree_setup_master(struct dsa_switch_tree *dst)
{
- struct dsa_port *cpu_dp = dst->cpu_dp;
- struct net_device *master = cpu_dp->master;
+ struct dsa_port *dp;
+ int err;
- /* DSA currently supports a single pair of CPU port and master device */
- return dsa_master_setup(master, cpu_dp);
+ list_for_each_entry(dp, &dst->ports, list) {
+ if (dsa_port_is_cpu(dp)) {
+ err = dsa_master_setup(dp->master, dp);
+ if (err)
+ return err;
+ }
+ }
+
+ return 0;
}
static void dsa_tree_teardown_master(struct dsa_switch_tree *dst)
{
- struct dsa_port *cpu_dp = dst->cpu_dp;
- struct net_device *master = cpu_dp->master;
+ struct dsa_port *dp;
- return dsa_master_teardown(master);
+ list_for_each_entry(dp, &dst->ports, list)
+ if (dsa_port_is_cpu(dp))
+ dsa_master_teardown(dp->master);
}
static int dsa_tree_setup(struct dsa_switch_tree *dst)
--
2.23.0
next prev parent reply other threads:[~2019-10-21 20:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 20:51 [PATCH net-next v2 00/16] net: dsa: turn arrays of ports into a list Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 01/16] net: dsa: use dsa_to_port helper everywhere Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 02/16] net: dsa: add ports list in the switch fabric Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 03/16] net: dsa: use ports list in dsa_to_port Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 04/16] net: dsa: use ports list to find slave Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 05/16] net: dsa: use ports list to setup switches Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 06/16] net: dsa: use ports list for routing table setup Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 07/16] net: dsa: use ports list to find a port by node Vivien Didelot
2019-10-21 20:51 ` Vivien Didelot [this message]
2019-10-21 20:51 ` [PATCH net-next v2 09/16] net: dsa: use ports list to find first CPU port Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 10/16] net: dsa: use ports list to setup default " Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 11/16] net: dsa: mv88e6xxx: silently skip PVT ops Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 12/16] net: dsa: mv88e6xxx: use ports list to map port VLAN Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 13/16] net: dsa: mv88e6xxx: use ports list to map bridge Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 14/16] net: dsa: sja1105: register switch before assigning port private data Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 15/16] net: dsa: allocate ports on touch Vivien Didelot
2019-10-21 20:51 ` [PATCH net-next v2 16/16] net: dsa: remove dsa_switch_alloc helper Vivien Didelot
2019-10-21 22:34 ` [PATCH net-next v2 00/16] net: dsa: turn arrays of ports into a list Florian Fainelli
2019-10-22 11:43 ` Michal Vokáč
2019-10-22 19:41 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021205130.304149-9-vivien.didelot@gmail.com \
--to=vivien.didelot@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®