From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 696A0CA9EA0 for ; Tue, 22 Oct 2019 16:01:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45F832086D for ; Tue, 22 Oct 2019 16:01:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389000AbfJVQBK (ORCPT ); Tue, 22 Oct 2019 12:01:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:49712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387746AbfJVQBJ (ORCPT ); Tue, 22 Oct 2019 12:01:09 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0810720640; Tue, 22 Oct 2019 16:01:07 +0000 (UTC) Date: Tue, 22 Oct 2019 12:01:06 -0400 From: Steven Rostedt To: Mark Rutland Cc: jthierry@redhat.com, will@kernel.org, ard.biesheuvel@linaro.org, peterz@infradead.org, catalin.marinas@arm.com, deller@gmx.de, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, takahiro.akashi@linaro.org, mingo@redhat.com, james.morse@arm.com, jeyu@kernel.org, amit.kachhap@arm.com, svens@stackframe.org, duwe@suse.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/8] ftrace: add ftrace_init_nop() Message-ID: <20191022120106.234790cb@gandalf.local.home> In-Reply-To: <20191022153335.GC52920@lakrids.cambridge.arm.com> References: <20191021163426.9408-1-mark.rutland@arm.com> <20191021163426.9408-2-mark.rutland@arm.com> <20191021140756.613a1bac@gandalf.local.home> <20191022112811.GA11583@lakrids.cambridge.arm.com> <20191022085428.75cfaad6@gandalf.local.home> <20191022153035.GB52920@lakrids.cambridge.arm.com> <20191022153335.GC52920@lakrids.cambridge.arm.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Oct 2019 16:33:35 +0100 Mark Rutland wrote: > On Tue, Oct 22, 2019 at 04:30:35PM +0100, Mark Rutland wrote: > > On Tue, Oct 22, 2019 at 08:54:28AM -0400, Steven Rostedt wrote: > > > On Tue, 22 Oct 2019 12:28:11 +0100 > > > Mark Rutland wrote: > > > > | /** > > > > | * ftrace_init_nop - initialize a nop call site > > > > | * @mod: module structure if called by module load initialization > > > > | * @rec: the mcount call site record > > > > > > Perhaps say "mcount/fentry" > > > > This is the exact wording that ftrace_make_nop and ftrace_modify_call > > have. For consistency, I think those should all match. > > Now that I read this again, I see what you meant. > > If it's ok, I'll change those to: > > | @rec: the call site record (e.g. mcount/fentry) > Ack -- Steve