From: Christoph Hellwig <hch@infradead.org>
To: Omer Shpigelman <oshpigelman@habana.ai>
Cc: "oded.gabbay@gmail.com" <oded.gabbay@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] habanalabs: support kernel memory mapping
Date: Wed, 23 Oct 2019 02:20:35 -0700 [thread overview]
Message-ID: <20191023092035.GA12222@infradead.org> (raw)
In-Reply-To: <20191022063028.9030-1-oshpigelman@habana.ai>
On Tue, Oct 22, 2019 at 06:30:35AM +0000, Omer Shpigelman wrote:
> Changes in v2:
> - use a boolean parameter to indicate for kernel address rather than
> calling is_vmalloc_addr, as kernel and user addresses can overlap on
> some architectures.
That is still broken. Please use an actual kernel pointer instead of
losing all type safety by casting it an integer type.
next prev parent reply other threads:[~2019-10-23 9:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 6:30 Omer Shpigelman
2019-10-22 6:30 ` [PATCH v2 2/2] habanalabs: handle large memory on MMU Omer Shpigelman
2019-10-23 9:20 ` Christoph Hellwig [this message]
2019-10-23 13:39 ` [PATCH v2 1/2] habanalabs: support kernel memory mapping Omer Shpigelman
2019-10-24 1:28 ` Christoph Hellwig
2019-10-24 8:07 ` Omer Shpigelman
2019-11-11 6:37 ` Omer Shpigelman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023092035.GA12222@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oded.gabbay@gmail.com \
--cc=oshpigelman@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®