From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE2C5CA9EB9 for ; Wed, 23 Oct 2019 15:02:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8227C21906 for ; Wed, 23 Oct 2019 15:02:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cHO2Z3KY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406420AbfJWPCv (ORCPT ); Wed, 23 Oct 2019 11:02:51 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:44993 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390541AbfJWPCu (ORCPT ); Wed, 23 Oct 2019 11:02:50 -0400 Received: by mail-pf1-f194.google.com with SMTP id q21so13092302pfn.11; Wed, 23 Oct 2019 08:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+CWAItAYmWIbjE19EtlFeNSpGXkB58kb+qP39bZy8Bs=; b=cHO2Z3KYDcZ6jRjBOOsAdswjJsCO6jmKU63I/rEGv5PiEh8iOVyQn6Y4+cuuRQfcaz Q9GjAXRWEUDQQIikmKGh9G/J7S2U/YTt/0M/1BemR8O+SoBihQthJicMMqU584lNiQI2 i5uyFvk2MuRt1+ly4oop4VZ5RyHl1vrsCvERijBroBqXoxtmEQNvm7w4IdKve9/hCyd5 rLyNKVqekuRF+Yd9VjARoWbQs35DUYjs3DVpgaUNGiZ8mKn9F+Hei9VfiyVoArfeeUu/ FrHqOYXCqG6c/z6trRd7r1i/NGJc+258GqekbGmbnci3VmSGjUI/qKE3KlPBNkw1qjKy uC1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=+CWAItAYmWIbjE19EtlFeNSpGXkB58kb+qP39bZy8Bs=; b=ubOaBS7TG7GHqWjreMKgr8lrPIWA3E2yhveGVoNs036WPvY6Y/E3uwxTN+2svM1bOu YyrNfN7q1bkf2fGyBFDBU3GnDsUW4l1bB0N8NXztnmkzs0j8n1ZnoIqRj5bhv6rVCW/4 tBrKBT17Asb7jaD7A9SO7MP3LiRhp+4b96MDnynhfaZHR3DJSIIKMp1wXjBujGFKtBjQ U/3tr08r5ppHJwi/lw1gu6EfOUkPi2ixe0j7WNKUCkRSu+wxh9bfg8FUis20ekFW1hX/ ELRlT2qrI6XMfIQ+y2tRaFCTFHEaNyIsxkycmfzvfBEZjVnRuRMCurgvzJ7hDf+DInJ0 daKQ== X-Gm-Message-State: APjAAAUdrgwMakYvPjR+T5u+ALa//LH1a5s0I7ZeIc56z6jwjVZ/Gg+l tczC+nAeG9/PRLXfBWHvx/c= X-Google-Smtp-Source: APXvYqw+Awo/GLWhReDYxPmFXdeJ11IFaR/cRmaKL8N3spZeTAhOx2dIIPJ9KGcQrzQ/Dy5XC4WKJw== X-Received: by 2002:a63:28f:: with SMTP id 137mr9514675pgc.301.1571842969959; Wed, 23 Oct 2019 08:02:49 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id p66sm25021811pfg.127.2019.10.23.08.02.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Oct 2019 08:02:49 -0700 (PDT) Date: Wed, 23 Oct 2019 08:02:48 -0700 From: Guenter Roeck To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] watchdog: bd70528: Add MODULE_ALIAS to allow module auto loading Message-ID: <20191023150248.GB16612@roeck-us.net> References: <20191023124159.GA3490@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023124159.GA3490@localhost.localdomain> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 23, 2019 at 03:41:59PM +0300, Matti Vaittinen wrote: > The bd70528 watchdog driver is probed by MFD driver. Add MODULE_ALIAS > in order to allow udev to load the module when MFD sub-device cell for > watchdog is added. > > Fixes: bbc88a0ec9f37 ("watchdog: bd70528: Initial support for ROHM BD70528 watchdog block") > Signed-off-by: Matti Vaittinen Reviewed-by: Guenter Roeck > --- > > I'm not really sure if this is a bug-fix or feature but I guess the > Fixes tag won't harm, right? > > drivers/watchdog/bd70528_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/bd70528_wdt.c b/drivers/watchdog/bd70528_wdt.c > index b0152fef4fc7..bc60e036627a 100644 > --- a/drivers/watchdog/bd70528_wdt.c > +++ b/drivers/watchdog/bd70528_wdt.c > @@ -288,3 +288,4 @@ module_platform_driver(bd70528_wdt); > MODULE_AUTHOR("Matti Vaittinen "); > MODULE_DESCRIPTION("BD70528 watchdog driver"); > MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:bd70528-wdt"); > -- > 2.21.0 > > > -- > Matti Vaittinen, Linux device drivers > ROHM Semiconductors, Finland SWDC > Kiviharjunlenkki 1E > 90220 OULU > FINLAND > > ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ > Simon says - in Latin please. > ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ > Thanks to Simon Glass for the translation =]