mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org,
	vkoul@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com,
	srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com,
	Bard liao <yung-chuan.liao@linux.intel.com>,
	Rander Wang <rander.wang@linux.intel.com>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Sanyog Kale <sanyog.r.kale@intel.com>
Subject: [PATCH 08/18] soundwire: intel: reset pm_runtime status during system resume
Date: Wed, 23 Oct 2019 16:45:51 -0500	[thread overview]
Message-ID: <20191023214601.883-9-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20191023214601.883-1-pierre-louis.bossart@linux.intel.com>

The system resume does the entire bus re-initialization and brings it
to full-power. If the device was pm_runtime suspended, there is no
need to run the pm_runtime resume sequence after the system runtime.

Follow the documentation from runtime_pm.rst, and conditionally
disable, set_active and re-enable the device on system resume.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 drivers/soundwire/intel.c     | 30 ++++++++++++++++++++++++++++++
 include/linux/soundwire/sdw.h |  1 +
 2 files changed, 31 insertions(+)

diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 650581348732..c3cd7d2d5a34 100644
--- a/drivers/soundwire/intel.c
+++ b/drivers/soundwire/intel.c
@@ -1298,6 +1298,7 @@ static int intel_master_remove(struct sdw_master_device *md)
 
 static int intel_suspend(struct device *dev)
 {
+	struct sdw_master_device *md = to_sdw_master_device(dev);
 	struct sdw_cdns *cdns = dev_get_drvdata(dev);
 	struct sdw_intel *sdw = cdns_to_intel(cdns);
 	int ret;
@@ -1308,6 +1309,20 @@ static int intel_suspend(struct device *dev)
 		return 0;
 	}
 
+	if (pm_runtime_status_suspended(dev)) {
+		dev_dbg(dev,
+			"%s: pm_runtime status: suspended\n",
+			__func__);
+
+		/*
+		 * keep track of the state for the system resume, where
+		 * we will need to reset the pm_runtime status to active
+		 */
+		md->pm_runtime_suspended = true;
+
+		return 0;
+	}
+
 	ret = sdw_cdns_enable_interrupt(cdns, false);
 	if (ret < 0) {
 		dev_err(dev, "cannot disable interrupts on suspend\n");
@@ -1356,6 +1371,7 @@ static int intel_suspend_runtime(struct device *dev)
 
 static int intel_resume(struct device *dev)
 {
+	struct sdw_master_device *md = to_sdw_master_device(dev);
 	struct sdw_cdns *cdns = dev_get_drvdata(dev);
 	struct sdw_intel *sdw = cdns_to_intel(cdns);
 	int ret;
@@ -1366,6 +1382,20 @@ static int intel_resume(struct device *dev)
 		return 0;
 	}
 
+	if (md->pm_runtime_suspended) {
+		dev_dbg(dev,
+			"%s: pm_runtime status was suspended, forcing active\n",
+			__func__);
+
+		/* follow required sequence from runtime_pm.rst */
+		pm_runtime_disable(dev);
+		pm_runtime_set_active(dev);
+		pm_runtime_mark_last_busy(dev);
+		pm_runtime_enable(dev);
+
+		md->pm_runtime_suspended = false;
+	}
+
 	ret = intel_init(sdw);
 	if (ret) {
 		dev_err(dev, "%s failed: %d", __func__, ret);
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
index d756e41c9466..1950d2b467bd 100644
--- a/include/linux/soundwire/sdw.h
+++ b/include/linux/soundwire/sdw.h
@@ -577,6 +577,7 @@ struct sdw_master_device {
 	struct device dev;
 	int link_id;
 	struct sdw_md_driver *driver;
+	bool pm_runtime_suspended;
 	void *pdata; /* core does not touch */
 };
 
-- 
2.20.1


  parent reply	other threads:[~2019-10-23 21:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 21:45 [PATCH 00/18] soundwire: code hardening and suspend-resume support Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 01/18] soundwire: intel/cadence: fix timeouts in MSI mode Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 02/18] soundwire: fix race between driver probe and update_status callback Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 03/18] soundwire: bus: add PM/no-PM versions of read/write functions Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 04/18] soundwire: bus: write Slave Device Number without runtime_pm Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 05/18] soundwire: intel: add helpers for link power down and shim wake Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 06/18] soundwire: intel: Add basic power management support Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 07/18] soundwire: intel: add pm_runtime support Pierre-Louis Bossart
2019-10-23 21:45 ` Pierre-Louis Bossart [this message]
2019-10-23 21:45 ` [PATCH 09/18] soundwire: bus: add helper to reset Slave status to UNATTACHED Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 10/18] soundwire: intel: call helper to reset Slave states on resume Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 11/18] soundwire: bus: check first if Slaves become UNATTACHED Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 12/18] soundwire: add enumeration_complete signaling Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 13/18] soundwire: intel: disable pm_runtime when removing a master Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 14/18] soundwire: bus: disable pm_runtime in sdw_slave_delete Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 15/18] soundwire: stream: update state machine and add state checks Pierre-Louis Bossart
2019-10-23 21:45 ` [PATCH 16/18] soundwire: stream: only prepare stream when it is configured Pierre-Louis Bossart
2019-10-23 21:46 ` [PATCH 17/18] soundwire: stream: do not update parameters during DISABLED-PREPARED transition Pierre-Louis Bossart
2019-10-23 21:46 ` [PATCH 18/18] soundwire: intel: reinitialize IP+DSP in .prepare() Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191023214601.883-9-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jank@cadence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rander.wang@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=slawomir.blauciak@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®