From: Ricardo Ribalda Delgado <ribalda@kernel.org>
To: hverkuil-cisco@xs4all.nl, sakari.ailus@linux.intel.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ribalda@kernel.org>
Subject: [PATCH] v4l2-compliance: Allow all the selection targets for subdevs
Date: Thu, 24 Oct 2019 10:43:08 +0200 [thread overview]
Message-ID: <20191024084308.22749-1-ribalda@kernel.org> (raw)
Subdev can also have non-active pixels, and using the _DEFAULT targets
we can capture only the active pixels.
Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
---
utils/v4l2-compliance/v4l2-test-subdevs.cpp | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/utils/v4l2-compliance/v4l2-test-subdevs.cpp b/utils/v4l2-compliance/v4l2-test-subdevs.cpp
index 29987b31..e4923180 100644
--- a/utils/v4l2-compliance/v4l2-test-subdevs.cpp
+++ b/utils/v4l2-compliance/v4l2-test-subdevs.cpp
@@ -388,20 +388,19 @@ int testSubDevFormat(struct node *node, unsigned which, unsigned pad)
struct target_info {
__u32 target;
- bool allowed;
bool readonly;
bool found;
};
static target_info targets[] = {
- { V4L2_SEL_TGT_CROP, true },
- { V4L2_SEL_TGT_CROP_DEFAULT, false, true },
- { V4L2_SEL_TGT_CROP_BOUNDS, true, true },
- { V4L2_SEL_TGT_NATIVE_SIZE, true },
- { V4L2_SEL_TGT_COMPOSE, true },
- { V4L2_SEL_TGT_COMPOSE_DEFAULT, false, true },
- { V4L2_SEL_TGT_COMPOSE_BOUNDS, true, true },
- { V4L2_SEL_TGT_COMPOSE_PADDED, false, true },
+ { V4L2_SEL_TGT_CROP },
+ { V4L2_SEL_TGT_CROP_DEFAULT, true },
+ { V4L2_SEL_TGT_CROP_BOUNDS, true },
+ { V4L2_SEL_TGT_NATIVE_SIZE },
+ { V4L2_SEL_TGT_COMPOSE },
+ { V4L2_SEL_TGT_COMPOSE_DEFAULT, true },
+ { V4L2_SEL_TGT_COMPOSE_BOUNDS, true },
+ { V4L2_SEL_TGT_COMPOSE_PADDED, true },
{ ~0U },
};
@@ -447,7 +446,6 @@ int testSubDevSelection(struct node *node, unsigned which, unsigned pad)
if (ret)
continue;
have_sel = true;
- fail_on_test(!targets[tgt].allowed);
fail_on_test(check_0(sel.reserved, sizeof(sel.reserved)));
fail_on_test(sel.which != which);
fail_on_test(sel.pad != pad);
--
2.23.0
reply other threads:[~2019-10-24 8:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024084308.22749-1-ribalda@kernel.org \
--to=ribalda@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome