From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C97D4CA9EAF for ; Thu, 24 Oct 2019 18:17:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A988921872 for ; Thu, 24 Oct 2019 18:17:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504040AbfJXSRf convert rfc822-to-8bit (ORCPT ); Thu, 24 Oct 2019 14:17:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:59672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404839AbfJXSRf (ORCPT ); Thu, 24 Oct 2019 14:17:35 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A204D20684; Thu, 24 Oct 2019 18:17:33 +0000 (UTC) Date: Thu, 24 Oct 2019 14:17:31 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, mhiramat@kernel.org, bristot@redhat.com, jbaron@akamai.com, torvalds@linux-foundation.org, tglx@linutronix.de, mingo@kernel.org, namit@vmware.com, hpa@zytor.com, luto@kernel.org, ard.biesheuvel@linaro.org, jpoimboe@redhat.com, jeyu@kernel.org Subject: Re: [PATCH v4 15/16] module: Move where we mark modules RO,X Message-ID: <20191024141731.5c7c414c@gandalf.local.home> In-Reply-To: <20191024164320.GD4131@hirez.programming.kicks-ass.net> References: <20191018073525.768931536@infradead.org> <20191018074634.801435443@infradead.org> <20191021222110.49044eb5@oasis.local.home> <20191022202401.GO1817@hirez.programming.kicks-ass.net> <20191023145245.53c75d70@gandalf.local.home> <20191024101609.GA4131@hirez.programming.kicks-ass.net> <20191024110024.324a9435@gandalf.local.home> <20191024164320.GD4131@hirez.programming.kicks-ass.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Oct 2019 18:43:20 +0200 Peter Zijlstra wrote: > > > > CC [M] drivers/gpu/drm/i915/gem/i915_gem_context.o > > /work/git/linux-trace.git/kernel/trace/trace_events_hist.c: In function ‘register_synth_event’: > > /work/git/linux-trace.git/kernel/trace/trace_events_hist.c:1157:15: error: ‘struct trace_event_class’ has no member named ‘define_fields’; did you mean ‘get_fields’? > > call->class->define_fields = synth_event_define_fields; > > ^~~~~~~~~~~~~ > > get_fields > > make[3]: *** [/work/git/linux-trace.git/scripts/Makefile.build:265: kernel/trace/trace_events_hist.o] Error 1 > > make[3]: *** Waiting for unfinished jobs.... > > allmodconfig clean > > (omg, so much __field(); fail) Well it built without warnings and passed the ftrace selftests. I haven't ran it through the full suite, but that can wait for the v5. -- Steve