From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D2D1CA9EBB for ; Thu, 24 Oct 2019 19:32:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D809721A4A for ; Thu, 24 Oct 2019 19:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571945553; bh=IEMnt2X1cna5Tuh4NlqBIok4T4DSYcKCcY2DLN7AiF4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CWy4AYkhWsK8uyxxYMrjzlNy5XgwEpcM7OwKg9QkedkUuTNjqeqcWhfLmB2Iklub9 gS6ErS+c/rHKwZNzYzIYBGuj6zS7ZblYhuZ0F4u52cTApz5Irh6Q2uPUsH9TCuG13M Eq17xjJL+C31/xMiMA83WjzBl3YhMG1JsEDlIKYI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436766AbfJXTcc (ORCPT ); Thu, 24 Oct 2019 15:32:32 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:55344 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405801AbfJXTcc (ORCPT ); Thu, 24 Oct 2019 15:32:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vttDbr1v3prfmmWDLzJK+9NKCnOd94v+/MHN5g7eafo=; b=CbE96/yh2YdFVA3lDo3rtgUW1 1nKGHL5oUytt+gNKSOzQltYdAVrbAYGCVdJRDWR5ElYjyGcNuSfoi39rOSctuCSd82zqjizgevvl/ RItWIKeeCoaAlflHirdSRmTem7K9x/GW5JqAO0MdF/ne4ysAJoQm40sjHSG8N3Yunv5xU=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iNiqP-0003zz-Rk; Thu, 24 Oct 2019 19:32:25 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 55273274293C; Thu, 24 Oct 2019 20:32:25 +0100 (BST) Date: Thu, 24 Oct 2019 20:32:25 +0100 From: Mark Brown To: Gregory CLEMENT Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , linux-arm-kernel@lists.infradead.org, Thomas Petazzoni , "kernelci.org bot" , stable@vger.kernel.org Subject: Re: [PATCH] spi: Fix NULL pointer when setting SPI_CS_HIGH for GPIO CS Message-ID: <20191024193225.GM46373@sirena.co.uk> References: <20191024141309.22434-1-gregory.clement@bootlin.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0+35XlDF45POFHfm" Content-Disposition: inline In-Reply-To: <20191024141309.22434-1-gregory.clement@bootlin.com> X-Cookie: Filmed before a live audience. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0+35XlDF45POFHfm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 24, 2019 at 04:13:09PM +0200, Gregory CLEMENT wrote: > Even if the flag use_gpio_descriptors is set, it is possible that > cs_gpiods was not allocated, which leads to a kernel crash: >=20 > Unable to handle kernel NULL pointer dereference at virtual address 00000= 000 > pgd =3D (ptrval) > [00000000] *pgd=3D00000000 > Internal error: Oops: 5 [#1] ARM > Modules linked in: > CPU: 0 PID: 1 Comm: swapper Tainted: G W 5.4.0-rc3 #1 > Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) > PC is at of_register_spi_device+0x20c/0x38c > LR is at __of_find_property+0x3c/0x60 > pc : [] lr : [] psr: 20000013 Please think hard before including complete backtraces in upstream reports, they are very large and contain almost no useful information relative to their size so often obscure the relevant content in your message. If part of the backtrace is usefully illustrative then it's usually better to pull out the relevant sections. --0+35XlDF45POFHfm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2x/EgACgkQJNaLcl1U h9Dc+Qf7BOBELW73o6MOZxD5Uq2/Eahp26z5rN7PMc+EvRwda/BzHGhUTsTrotmX ppdm6tsBosW3dH8P6tbwXIIJHO11BO4ma/pbO5ZZloEqeo3Zvxt89+AxZD4roa26 GEnDMWLNn2Y3L0YENJzNelC3RMBY7sIv7wMgiGZR7qadTFrx6Y3v+VLAEEEsSnA6 f3AmuiyCWtiNyuhi1gIst/hGeDzLyNOGVJuNfH7SV4RbQVN51k9Cam5JEaBB6NjK PTKDGt0u2CGaKQxTZRHb8al+SznFqEk0eKU06KEWpdcPJAOPW24cLVXl2YAb6b2l yg1Wz4gE+9D908qKFUl3e+fimC6N+A== =pES0 -----END PGP SIGNATURE----- --0+35XlDF45POFHfm--